GithubHelp home page GithubHelp logo

Comments (7)

Urigo avatar Urigo commented on June 8, 2024

@netanelgilad have you seen it?

from meteor-ionic.

netanelgilad avatar netanelgilad commented on June 8, 2024

It seems like these are templates that are a part of ionic and they already use the curly braces notation.. It is the same problem we had in using other angular solutions that include their own template. @Urigo do you remember what we did there if we had a solution?

from meteor-ionic.

Xample avatar Xample commented on June 8, 2024

What about simply preprocessing all the files ?

sed -e 's/{{/[[/g' -e 's/}}/]]/g' ionic-angular.js >> ionic-angular-brackets.js

By the way, there is only 8 occurrences of curly braces within the source, compared to all the directives it is quite small. This is the reason why it took me few days before discovering the issue…

from meteor-ionic.

Urigo avatar Urigo commented on June 8, 2024

My opinion is to first copy the code instead of using bower and manually change all the delimiters.
To first make it work.

Then, we should create an issue in Ionic to support Angular's ability to change delimiters.

Then maybe to pull request Ionic ourselves to add that support to them.

What do you think?

from meteor-ionic.

Xample avatar Xample commented on June 8, 2024

@Urigo ok opened an issue here: ionic-team/ionic-framework#2681

from meteor-ionic.

Urigo avatar Urigo commented on June 8, 2024

Great, I've also added the issue here:
https://github.com/Urigo/angular-meteor/blob/master/External-issues.md

from meteor-ionic.

Urigo avatar Urigo commented on June 8, 2024

We can close this now that the new urigo:angular version you don't need to use different delimiters

from meteor-ionic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.