Comments (10)
Basically, if you remove the "allowJs"
, "experimentalPipelineStage1"
, and "noEmit"
options and specify "outDir": "./build"
it will emit to ./build
with types and sourcemaps when you run tsc
.
from urql.
I can't seem to get type hinting working. I think it's because theyre hidden under a types/ subfolder and not next to the .js or in a @types package.
Would you consider moving them to @types/urql?
from urql.
I explored a route with using dts-gen but it is not that great maybe using tsc
instead of babel for the compilation would be better but I am not sure why babel was used in the first place.
from urql.
i'm not super familiar with generating or providing types. any tips or pr?
from urql.
How do you want it emitted? As commonjs, or es2015 modules?
Also, not sure what benefit you're looking for out of using babel over just tsc as you aren't using the pipeline operator anywhere that you have tagged in the babel plugins.
from urql.
I would second this
Basically, if you remove the "allowJs", "experimentalPipelineStage1", and "noEmit" options and specify "outDir": "./build" it will emit to ./build with types and sourcemaps when you run tsc.
If we come to the conclusion we want to do it with tsc
I can do a pr. But I don't get the babel setup.
from urql.
There are also a number of other adjustments I would make to the repo, like moving tests
outside of the src
directory so they don't get sucked into the distributable that's published to NPM. (You can still type check the test files by having a tsconfig that is for the IDE essentially and another one that extends it for building which excludes the tests)
from urql.
@dyst5422 -- Tests are already ignored for publishing (modulo a small oversight with one file that I've just put up #28 to fix). Take a look at https://unpkg.com/urql/ to see what we actually publish (and lib|es/tests/utils/fetch-mock.js
being there is what I've just fixed).
from urql.
Also, for anyone discussion CJS vs. ESM, our publishing approach is both. See, e.g.:
Hope that helps!
from urql.
I'm reluctant to publish the actual .ts source, but as far as definitions, should I be publishing to @types, or running tsc and pointing at that from package.json? cc @danielrossenwasser
from urql.
Related Issues (20)
- Field return issue depending on field order in same query HOT 3
- Vue: Promisified useQuery resolves to late with refreshAuth in @urql/exchange-auth HOT 4
- data and error both undefined for 500 status with an `errors` key in response HOT 2
- Graphcache cache invalidation no longer working within optimistic update HOT 3
- `@urql/next` publishes CommonJS with invalid React usages HOT 1
- RFC: Option to hide warnings when in development
- Infinite initialization? (with Graphql-codegen and Next.js 13) HOT 4
- RFC: Add APQ support for Contentful (CMS) HOT 3
- persistedExchange(APQ) doesn't work with cacheExchange due to Document Caching HOT 2
- RFC: Add `onCacheHydrated` event
- useQuery re-render even if cached when neighbor data (but not retrieved by useQuery) is newly retrieved HOT 4
- RFC (Graphcache): Change SerializedEntries to provide Map to storage adapters HOT 3
- Component does not suspend when changing variables while using `suspense: true`
- RangeError: Maximum call stack size exceeded when using persistedExchange in front of ssrExchange HOT 7
- Saving a component in Next.js development mode casues infinite requests HOT 1
- Stale || Fetching doesn't actually represent when operations are in progress while offline HOT 5
- storage missing in typed graphcache HOT 3
- Request Policy set to cache-only throws error during build of next.js app with document cache
- request-policy-exchange behavior differs between dev & production HOT 2
- @urql/next registerUrql fails in Next.js app due to TypeError: React.cache is not a function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from urql.