GithubHelp home page GithubHelp logo

child-labor's People

Contributors

akshaysanganal avatar aquilent-trumainejohnson avatar chetan1kale avatar ggruse avatar gnanendra18 avatar lehaine avatar mikepulsiferdol avatar pbhatt17 avatar skeejay avatar te-chetan avatar tyronegrandison avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

child-labor's Issues

Release 3D-Touch

@skeeJay Can you please provide some information about what part of the app was updated with 3D-Touch capabilities? I need to provide some information to the QA team about what they're looking for in testing.

Thanks!

Add Link to Country Web Page to Country Screens

Since iOS and Android do not read the structure of PDFs currently can you please add a link to the countries web page so people using assistive technologies like screen readers(VoiceOver) can have a more accessible experience as long as they have connection to the internet.

For more information about this problem you can look at issues #48 and #49 for issues found when only having full information as a PDF, along with the text being too small to read on an iPhone.

Below is some background information on why iOS and Android currently don't read PDFs correctly.

I asked my Twitter followers, and Sam Joehl (@Mixolydian) responded with an article that states iOS and Android PDF readers on mobile devices do not currently read PDF structure (headings, lists, tables, etc.) correctly.

The article is - PDF Accessibility on Mobile Devices by SSB BART Group's Jonathan Avila

and here is a short excerpt from it:

What PDF features are generally not accessible?

Structural information such as the presence of headings, lists, tables, and images are not indicated using the default iOS or Android PDF viewer installed with Google Drive or Adobe Reader. In addition, the ability to navigate between units such as lines, paragraphs, headings, lists, etc. are not available.

Country PDF Text too Small to Read on iPhone

While looking at the application to check on the PDFs that were added to the "Sweat and Toil" country screens, I noticed that the text for the PDFs is so small to read even in landscape mode. Having the PDF available on an iPhone only makes it difficult for people to read without zooming in and having to scroll left and right to read the content.

VoiceOver Not Reading Country PDF Headings Correctly

While using VoiceOver to read a PDF or two I noticed that the PDF was read as one continuous document. VoiceOver never read any headings. I will try this again and then use JAWS on my PC to read the same PDF from the website.

VoiceOver Not Reading Country PDF Tables Correctly

While reading the tables, VoiceOver read what would be the headings from left to right and then read the content in the table from top to bottom left to right. I will try this again using JAWS on my PC to read the same PDF from the website.

Preliminary Accessibility and QA Testing of iPhone Findings

New ILAB iPhone Application Issues

QA team started doing preliminary testing of the new ILAB iPhone application.

We have listed the issues by screen and if it is an accessibility issue, recommendation for usability improvement, question, etc. We still need to test the application with VoiceOver (iPhone screen reader).

Home Screen

  • The poor color contrast of the greater than sign ">" which is used to get a person to the section they are trying to get to. The disclosure indicator is system standard and not editable; you can see more information in the Human Interface Guidelines at https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/ContentViews.html#//apple_ref/doc/uid/TP40006556-CH13-SW3 Still think it's an issue even if Apple says it's fine. 09/09/2015
  • The more information icon at bottom right of the screen is hard to see because of poor color contrast. This has been adjusted in subsequent betas; the current appearance is: Still think it's an issue even though it's better. 09/09/2015
    ![Image of home screen](http://i.imgur.com/vCpBmYS.jpg =250x)
  • QUESTION - How come the line under the "Countries" and "Goods" navigation do not go all the way to the left as the other two lines do? Item separator lines are system standard and not editable; in general, the outlines at the top and bottom of a table item group go all the way across, and lines in between any two items leave a margin stylistically. 09/09/2015

More Information Screen

  • RECOMMENDATION - Might be useful to have a glossary of terms page along with a short description of what each of the icons represents. I'll bring it up internally, but our intention was never to make the icons totally unique or descriptive on their own, but just as quick way to view the type of good and then tap through for more information.
  • RECOMMENDATION - The "Done" link/button should be on the left side where most of the other back buttons are in other applications. iOS convention is that "Back" buttons are placed on the left but "Done" buttons are placed on the right, the reason being that "Back" takes you to a previous navigation screen which slides in from the left, but "Done" closes a model which slides in from the bottom. There is more discussion of this available at http://globalmoxie.com/blog/ios-button-placement.shtml 09/09/2015

Methodology Screen

  • The "TDA report introduction" links to a scanned PDF - http://www.dol.gov/ilab/reports/child-labor/findings/2013tda/2013tda.pdf Will have to double check it with JAWS or VoiceOver. Doing a quick review of this document, it seems to be a scanned PDF. Would this point to the newer 2014 version of the document? Because this simply links to an external URL in Safari, we don't have control over this from the app, so it's OUT OF SCOPE for the app. PDF links have been removed from the application. 09/09/2015
  • We have the same issue as above with the "TVPRA report Introduction" PDF - http://www.dol.gov/ilab/reports/pdf/TVPRA_Report2014.pdf Because this simply links to an external URL in Safari, we don't have control over this from the app, so it's OUT OF SCOPE for the app. PDF links have been removed from the application. 09/09/2015
  • We need to check the PDF from the "EO report introduction" link to see if the PDF is accessible - http://www.dol.gov/ilab/reports/pdf/EO_Report_2014.pdf Because this simply links to an external URL in Safari, we don't have control over this from the app, so it's OUT OF SCOPE for the app. PDF links have been removed from the application. 09/09/2015

Countries Screen

Countries Screen - A - Z

  • The text of country "Falkland Islands (Islas Malvinas)" gets truncated when in portrait mode, along with about six others. This is standard iOS behavior for table view items with long names in a table view. The user should be able to view the whole name by tapping through to the country's profile screen. 09/14/2015

Countries Screen - By Level

  • There a few headings at the top of the page with no countries under them, along with most of them under the "No Data" heading. My guess is you are still working on these. This was a bug in a prior beta; it's been corrected, and the countries are now distributed throughout the levels. 09/14/2015

Individual Countries Screen

  • The poor color contrast of the greater than sign ">" which is used to get a person to the section they are trying to get too. The disclosure indicator is system standard and not editable; more information is available in the Human Interface Guidelines at https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/ContentViews.html#//apple_ref/doc/uid/TP40006556-CH13-SW3 Still think it's an issue even if Apple says it's fine. 09/09/2015
  • The goods icons need their color contrast improved. It is hard to see them. Viewing them on their phone outside in bright sunlight will make this even more difficult. This matches the appearance of goods in their other locations in the app for visual consistency, which has been governed by usability considerations. See the first bullet under Exploitation Type Screen for more information.
  • Unless a goods icon gets split on the right side, it is difficult to tell if there are more of goods in the carousel list. We should add previous and next arrows to make this easier to figure out unless the list only fills the screen. This is standard behavior for a horizontally scrolling iOS collection view, similar to the behavior of any vertically scrolling page. iOS doesn't provide any option for indicators besides the collection view's own scroll bar—arrows would likely look too similar to the table view's disclosure icon, which indicates tappability instead of scrollability in the parlance of iOS. 09/09/2015
  • Text under the goods icons sometimes is not fully written out unless you go to landscape mode and even then some are not fully visible. Similar to the standardized way that iOS table view items truncate long names, I constructed this collection view to do the same. The intention, as with Apple's own assumption on table views, is that a user can table to go to the good's profile screen to see the whole name. Still think it's an issue even if Apple says it's fine. 09/09/2015
  • Not sure best way to tell people that the goods icons can be tapped so see all countries that have issues with this particular good. Might want to add information about this in the "More Info" section. A good suggestion, and I will run it by ILAB, who is generating the content for the "More Info" section.
  • The little icons under the goods icons are hard to tell what they are. The design is defined by the Exploitation Type Screen, see first bullet under that section for response.
  • RECOMMENDATION - Pages have the additional word "Advancement" on most or all individual country pages. This has been corrected in subsequent betas. 09/09/2015
  • RECOMMENDATION - The "More" link at the end of the paragraph should be left justified, so it's easier to see and read for those with reading issues such as dyslexia. This isn't a convention in the HIG, but a similar button appears in Apple's own App Store, and I was mimicking Apple's implementation—the placement on the right seems to be a visual indication that more text will be appended to the end. Still think it's an issue even if Apple says it's fine. 09/09/2015

Individual Countries - Suggested Actions Screen

  • The poor color contrast of the headings such as "Laws", "Enforcement", etc. Should probably make this text bold/strong so when you have no "No Actions" it's easier to tell the heading from the content. These are system standard table view headings and footers, and we don't have control over their styling. "Laws," "Enforcement," etc., are standard table group headers styled by the operating system. "No Actions" is a standard table group footer styled by the operating system. Still think it's an issue even if Apple says it's fine. 09/09/2015
  • The first item under "Enforcement" for Brazil does not list the entire text even in landscape mode. Why not list everything that is available on the screen? This has been corrected in subsequent betas. 09/09/2015
  • Why no make the items under a heading an unordered/bulleted list. Doing this will help those using VoiceOver to get an idea of how many items are in the list. iOS app layout does not use HTML; iOS's standard control for listing items is the table view. 09/09/2015

Individual Countries - Statistics Screen

  • The words under the heading "Working" have poor color contrast and are difficult to read even without bright sunlight. UPDATE 9/13/15: Addressed by #42 Color contrast doesn't look like it changed much if any. 09/14/2015

Individual Countries - International Conventions Screen

  • Poor color contrast of the headings. These are system standard table view headings and footers, and we don't have control over their styling. Still think it's an issue even if Apple says it's fine. 09/09/2015
  • The word "YES" that is in green has poor color contrast and should be made dark to say a forest green. UPDATE 9/13/15: Addressed by #41 Color contrast doesn't look like it changed much if any. 09/14/2015

Individual Countries - Legal Standards Screen

  • The word "YES" that is in green has poor color contrast and should be made dark to say a forest green. UPDATE 9/13/15: Addressed by #41 Color contrast doesn't look like it changed much if any. 09/14/2015
  • QUESTION - What are the additional numbers in parentheses on this screen? UPDATE 9/13/15: These appear on legal standards referring to "minimum age"; this is the minimum age set by the country for that legal standard. 09/14/2015
  • The text describing the age is not fully written out in portrait mode and could be confusing for those using the application that are not experts In information. This has been corrected in future betas. In the latest version I have this issue has not been corrected. 09/14/2015

Individual Countries - Report PDF Screen

  • We need to make sure all the PDF's are readable to VoiceOver users. Plus, the text in them is way to small to read on the persons iPad let alone the iPhone. These are being removed in the launch version of the app. 09/09/2015

Goods Screen

  • The poor color contrast of the greater than sign ">" which is used to get a person to the section they are trying to get too. The disclosure indicator is system standard and not customizable. Still think it's an issue even if Apple says it's fine. 09/09/2015

Goods - A - Z Screen

  • The poor color contrast of the greater than sign ">" which is used to get a person to the section they are trying to get too. The disclosure indicator is system standard and not customizable. Still think it's an issue even if Apple says it's fine. 09/09/2015
  • RECOMMENDATION - Should add the alphabetic list to the right as on other pages so people can skip down the list to the section they want. This is feasible, and would seem appropriate for this alphabetically-organized list. I'll bring this up with ILAB to see if they approve of this design recommendation.

Goods - By Sector Screen

  • RECOMMENDATION - Should add the alphabetic list to the right as on other pages so people can skip down the list to the section they want. This is a totally logical recommendation, and I mocked this up, but we decided that in practice, it doesn't really work for sections that are anything other than alphabetic. Instead of 26 one-letter sections that run neatly and narrowly down most of the side of the screen, you'd have only five or so very long section names.......iOS centers them vertically on the right side of the screen, pushing the rest of the content of the page left and creating massive whitespace along the entire right side of the screen above and below these 5 tiny options. We decided not to add a section index to any list that wasn't groups alphabetically. 09/09/2015

Individual Goods Screen

  • When in Portrait mode and a few cased in landscape mode the top heading is not fully visible. The heading should go to a second or third line if need be. Some people using the application might not be experts in all the goods or other information. Example - "Bidis (hand-or" shows up in portrait mode, while in landscape mode it reads "Bidis (hand-rolled cigar..." when the full heading is "Bidis (hand-rolled cigarettes)". This would indeed be the desired behavior, but may not be fixable by submission on Monday. I'll try hard to find a fix before then.
  • When selecting labor types such as "Child Labor" therefore I can only see all the other types that don't apply and not the grayed out ones. I would expect them not to be part of the list anymore. For an example see "Bricks" and tap on "Forced Child Labor" where 10 or so items are now grayed out. A good example is how on the "Exploitation Types" page when you tap on one labor type all those that do not apply disappear. This was a design decision by ILAB, but I will ask them to revisit.
  • The little "hand" and "people" icons are hard to see because of their small size especially when there is more than one of them per country. See third bullet under Exploitation Type Screen for design rationale. 09/14/2015
  • RECOMMENDATION - Possibly add an alphabetic list to the longer lists that are more than a page. Might not need whole alphabetic list but only the letters needed. This was a design decision by ILAB. I will ask them to revisit.

Exploitation Type Screen

  • The goods icons need their color contrast improved. It is hard to see them. Viewing them on their phone outside in bright sunlight will make this even more difficult.
    I’m concerned about increasing this too much, because the darker the goods are, the more the exploitation symbols on top of them get lost in them visually. See what happens when I increase the darkness of them by 25%: Even with upping the color 25% it still doesn't pass the color contrast ratio of 4.5:1. This will make it even harder to see out in bright sun. Still think it's an issue even if Apple says it's fine. 09/09/2015

Image of exploitation screen

It becomes much harder to see that the symbols on top of them are even separate entities.

I will tinker with making them a shade darker, perhaps 5%, and see if that helps their own visibility without obscuring the exploitation symbols. But in general, for the intended use cases of this screen, it’s not a priority that the user necessarily be able to visually identify every good. The most important use of this screen is to see which countries have the most goods and what types of exploitation dominate. Thus, I’m reluctant to increase the recognizability of the individual goods at the expense of the exploitation types attached to each.

  • Unless a goods icon gets split on the right side, it is difficult to tell if there are more of them on the list. We should add previous and next arrows to make this easier to figure out unless the list only fills the screen. This is standard behavior for a horizontally scrolling iOS collection view, similar to the behavior of any vertically scrolling page. iOS doesn't provide any option for indicators besides the collection view's own scroll bar—arrows would likely look too similar to the table view's disclosure icon, which indicates tappability instead of scrollability in the parlance of iOS. Still think it's an issue even if Apple says it's fine. 09/09/2015
  • The little hand and people icons are hard to see because of their small size especially when there is more than one of them per country. So, some context on this issue: our design requirements were to create a screen that allowed a broad overview of all countries, the goods in each, and the types of exploitation on each good. Fitting this much content on the screen to make the overview useful took many design discussions and iterations, and required shrinking the goods, and thus the exploitation symbols “on top” of them, to an appropriate size (12 pixels by 12 pixels) without losing their ability to be distinguished. To accomplish this, we carefully constructed the three exploitation symbols so that they would be as easy to see as possible at this scale. First, we made the two types of icons—the hand and the person—as differently shaped as possible, so that even if a user had poor eyesight, color-blindness, or a low resolution screen, the basic symbol still resolved to a distinct and recognizable shape: the hand becomes a circle, and the person becomes a diagonal slash. (We had to accomplish this with symbols that were also politically correct, which took a great deal of discussion and deliberation over many weeks.) We also color coded them so they are distinguishable by color—again, both for users with lower eyesight and for quick scanning—and tested the selected colors with colorblind users to make sure they could distinguish behind the two symbols. Though it was extremely difficult to satisfy all the requirements, we believe we accomplished it, and our testing confirmed this to our satisfaction.
  • RECOMMENDATION - Should add the alphabetic list to the right as on other pages so people can skip down the list to the section they want. This is a totally logical recommendation, and I mocked this up, but we decided that in practice, it doesn't really work for sections that are anything other than alphabetic. Instead of 26 one-letter sections that run neatly and narrowly down most of the side of the screen, you'd have only five or so very long section names.......iOS centers them vertically on the right side of the screen, pushing the rest of the content of the page left and creating massive whitespace along the entire right side of the screen above and below these 5 tiny options. We decided not to add a section index to any list that wasn't groups alphabetically.

Now as you complete correcting the issues listed above you can check them off, and we can test them again to see if that is correct. If something is out of scope you can add "OUT OF SCOPE" after the check box. It would be helpful to add the date the update was made to the beginning of the issue, so we know which ones were updated when.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.