Comments (6)
I see that I should probably have used this to import Clubhouse:
import * as Clubhouse from 'clubhouse-lib';
Maybe a Typescript example would fix that confusion. I'll see if I can't extend the README to include this.
from shortcut-client-js.
Ooh, nice find @chpspiir. Admittedly, we don't use this library from TypeScript here at Clubhouse, so we haven't run into this yet.
The create
method is defined here: https://github.com/clubhouse/clubhouse-lib/blob/540abbfe82cc5d06caae9b73468a455cee72572d/typings/index.d.ts#L46, however, I'm not super clear on how type definitions for modules works.
I'd love for this to be clearer for future TypeScript users, either by updating the README or improving the type definition!
from shortcut-client-js.
The above fix that I posted ended up not working anyway. So the issue still stands π€
I am at the same place as you with regards to the type definitions. I tried looking, but I kinda gave up when I found a work-around.
from shortcut-client-js.
It looks like @j-martin is successfully using Clubhouse.create
in their TypeScript project: https://github.com/andjosh/clubhouse-cli/blob/d63af74a6129c5cbf306c5cf15cfbc490bb1bc56/src/lib/client.ts#L1-L12
@chpspiir would you mind putting together a repro case for this, hopefully as a failing test in a PR to this project, so that we can address it for you?
from shortcut-client-js.
Sorry, it does indeed work. Sorry about the confusion π
from shortcut-client-js.
No worries! Happy to have folks using the library. Feel free to reach out or open other issues if you have more questions.
from shortcut-client-js.
Related Issues (20)
- Type StoryChange does not include new external_links property
- `external_tickets` is no longer a valid field
- Search by Pull Request HOT 4
- Any guidance on using File Upload? HOT 3
- Migrate to Shortcut HOT 1
- Add support for Get-Workflow HOT 1
- π Complete rewrite for v1 HOT 2
- How to get the org-public-id needed for Get/List Member? HOT 1
- Missing implementation for Product Area and Skill Set HOT 3
- CORS Header βAccess-Control-Allow-Originβ Missing Error
- Paginator
- Error: Error: Response for preflight has invalid HTTP status code 401(Solved)
- Swagger schema issue HOT 1
- listStories does not include the `description` field. HOT 3
- external_id param missing from StoryChange type HOT 1
- Stories do not have `external_links` typed HOT 2
- fetch-everywhere dependency causing npm audit failure HOT 1
- New release ? HOT 3
- Missing external_links field on type "Story" HOT 2
- deleteStoryComment throws error on 204 No Content
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shortcut-client-js.