Crashing when receiving high load of messages about smssync

[mandric]

Hrm I think I have a patch... this seems to fix it for me.

--- a/src/org/addhen/smssync/services/SmsReceiverService.java
+++ b/src/org/addhen/smssync/services/SmsReceiverService.java
@@ -450,6 +450,17 @@ public class SmsReceiverService extends Service {
         return msgs;
     }

+   synchronized protected static WifiManager.WifiLock getWifiLock(Context context) {
+        // keep wifi alive
+        if (wifilock == null) {
+            WifiManager manager = (WifiManager) context.getSystemService(Context.WIFI_SERVICE);
+            wifilock = manager.createWifiLock(CLASS_TAG);
+            wifilock.setReferenceCounted(true);
+        }
+
+        return wifilock;
+    }
+
     /**
      * Start the service to process the current event notifications, acquiring
      * the wake lock before returning to ensure that the service will run.
@@ -467,14 +478,9 @@ public class SmsReceiverService extends Service {
                 mStartingService.setReferenceCounted(false);
             }

-            // keep wifi alive
-            if (wifilock == null) {
-                WifiManager manager = (WifiManager)context.getSystemService(Context.WIFI_SERVICE);
-                wifilock = manager.createWifiLock(CLASS_TAG);
-            }
-
             mStartingService.acquire();
-            wifilock.acquire();
+            if (!getWifiLock(context).isHeld()) 
+                getWifiLock(context).acquire();
             context.startService(intent);
         }
     }

[eyedol]

@mandric Are you sending the 50+ messages at a goal? And oh 2.x.x should support Android 2.x and above. It only dropped support for 1.6. I'll try and reproduce the issue and patch the code with your fix.

[mandric]

Pretty sure I had the same issue whether I setup a syncurl or not. I'm not sure what you mean by goal.

I should start using the 2.x branch then, I had trouble compiling it with that target. e.g. android update project --target "android-10" -p . I'll try again...

[eyedol]

@mandric I meant 50 messages at a time?