GithubHelp home page GithubHelp logo

Comments (4)

BillCleveland-USRA avatar BillCleveland-USRA commented on August 24, 2024 1

Met with Adam. Agree this needs further research to make sure the workaround won't break any other functionality in GDT.

from gdt-core.

derekocallaghan avatar derekocallaghan commented on August 24, 2024

Hi @AdamGoldstein-USRA,

Just wanted to check whether the suggested workaround that excludes the call to SkyCoord() is okay with you? If so, I'll create a PR.

Thanks

from gdt-core.

AdamGoldstein-USRA avatar AdamGoldstein-USRA commented on August 24, 2024

@derekocallaghan Please checkout PR #38 and see if it works for you.

Your proposed fix would work only for EquatorialPlot, and the problem would still be present for GalacticPlot and SpacecraftPlot. The intent is to allow plotting in other frames (currently Galactic and spacecraft), and after you identified the root cause of the issue, I think the fix in PR #38 addresses that for any frame.

from gdt-core.

derekocallaghan avatar derekocallaghan commented on August 24, 2024

Thanks @AdamGoldstein-USRA, that was just a quick workaround to get the correct plot here. I've tried the modifed lib.py and sky.py and the plot is rendered as expected with the following, so I'll close this issue:

eqplot = EquatorialPlot()
eqplot.add_localization(gbm_healpix, gradient=True)

Fixed by #38

from gdt-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.