Sidekiq::Status::ClientMiddleware has no way to specify expiration about sidekiq-status

[lucke84]

Super interested in this topic, and I think @bejmuller is too!

[utgarda]

Guys, sorry about the docs one more time, you can specify custom expiration globally through server middleware initialization params, just look at this:
https://github.com/utgarda/sidekiq-status/blob/master/lib/sidekiq-status/server_middleware.rb#L11
also, to specify it on per-worker basis, just make sure worker.respond_to?(:expiration) == true and set it there ( see the same file, server middleware ).

[ivanovv]

@utgarda I think both ways you suggested are not going to work...
Lets follow the code for the queued job
https://github.com/utgarda/sidekiq-status/blob/master/lib/sidekiq-status/client_middleware.rb#L11
from here

def call(worker_class, msg, queue, redis_pool=nil)
      store_status msg['jid'], :queued, nil, redis_pool
      yield
end

passes explicit nil
store_status passes that nil to store_for_id https://github.com/utgarda/sidekiq-status/blob/master/lib/sidekiq-status/storage.rb#L32
store_for_id uses that nil or constant here https://github.com/utgarda/sidekiq-status/blob/master/lib/sidekiq-status/storage.rb#L18

conn.expire id, (expiration || Sidekiq::Status::DEFAULT_EXPIRY)

If there is no some magic, then the queued job will receive Sidekiq::Status::DEFAULT_EXPIRY

Correct me if I'm wrong.

[utgarda]

@ivanovv Got your point. I'm on it.

[shyamster]

@utgarda, did you get a chance to work on this? I'm facing the same issue. Setting expiration does not work either in the worker or via the middleware initialization params

[topherhunt]

I believe I'm running into this same issue, can someone confirm that the following is in the same bucket? In my Sidekiq worker I've defined expiration thus:

  def expiration
    @expiration ||= 60 * 60 * 6 # 6 hours
  end

but in the Redis queue I'm seeing indication that status keys are set to expire after 30 minutes:

1433183351.762414 [0 127.0.0.1:49224] "expire" "sidekiq:status:d2347b9afde8c47deeaa70eb" "1800"

I only figured this out after wasting hours looking elsewhere for the problem, since I had set expiration: 6.hours in the ServerMiddleware config but eventually figured out that Sidekiq-Status wasn't respecting this option.

Update: I worked around this issue with the following monkeypatch in config/initializers/sidekiq-status.rb:

module Sidekiq::Status
  remove_const :DEFAULT_EXPIRY
  DEFAULT_EXPIRY = 60 * 60 * 6 # 6 hours
end