Completed jobs in Sidekiq::Status::Web about sidekiq-status

[utgarda]

Yup, it's a feature, at least so far. I can see you started implementing showing completed jobs in your branch?

[marcboquet]

Yep, have a first implementation but needs a bit more work.
Would you be open to merge it once it's done?

[utgarda]

Absolutely. That'd be fabulous. I don' use Sidekiq currently, so I can't point the right direction for new features, all I can do is answer people's questions about how it works, and that's it. And most of the time that's not required, cause the codebase is tiny and ( hopefully ) quite readable. Sharing a feature that is important enough for you to implement is very likely what other users need. Also, it's just a cool thing to do :)

[vanboom]

I think this is related to the job not hanging around until expiration...

Sidekiq::Status::status( job_id )

starts returning nil as soon as the job is completed, so I am not able to see that the job has been completed by polling status.

[pramodshinde]

@utgarda I drilled down this issue and observed following

In Sidekiq::Status::Web module

  queue = Sidekiq::Workers.new

• Above API, only return jobs which are in progress i.e. with status :working
• I also looked into @marcboquet's code on his feature branch but I'm not liking his hack to show up completed jobs on statuses tab.
  I started working on this feature at branch (not committed any code yet).

For this I am thinking of storing some additional info with status for a job instead of using above API.