GithubHelp home page GithubHelp logo

Comments (2)

PhilipTrauner avatar PhilipTrauner commented on August 26, 2024 3

I get that replicating the GitHub style is what you are going for, but wouldn't it make more sense to just set the max-width of the timeline to 100% and then let the user set their own desired width in the .utterances class? The default width could still be set to 760px this way, while allowing the utterances timeline to scale properly when paired with content that makes use of more horizontal screen real estate.

from utterances.

jdanyow avatar jdanyow commented on August 26, 2024

hi @PhilipTrauner - the 760px value was chosen to match github's style. If you open the dev tools while on this page and execute the following code you should see 760px:

window.getComputedStyle(document.querySelector('.discussion-timeline')).width

I think this width was chosen to optimize cpl for reading.

from utterances.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.