GithubHelp home page GithubHelp logo

Comments (3)

phil-opp avatar phil-opp commented on May 18, 2024 4

Sounds good to me! However, I think there are some sites that use the query string for determining which article to show (e.g. ?article_id=1234).

Maybe we can use the rel=canonical link when present and default to ignoring query string/anchor else?

from utterances.

phil-opp avatar phil-opp commented on May 18, 2024 1

I know that I'm a bit late, but thanks for fixing this so quickly! It works without problems now.

from utterances.

jdanyow avatar jdanyow commented on May 18, 2024

I agree, I think this is a bug. We should ignore both querystring/search and hash/anchor by default. Also need to normalize trailing backslash.

For example, this url in the address bar:

https://os.phil-opp.com/minimal-rust-kernel/?foo=bar&b#anchor

Should result in a search for issues whose title contains:

https://os.phil-opp.com/minimal-rust-kernel

Thoughts?

from utterances.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.