optout + build failed about vaadin-usage-statistics

[Artur-]

npm run disable should rename vaadin-usage-statistics.js to vaadin-usage-statistics.js.bak and then vaadin-usage-statistics-optout.js to vaadin-usage-statistics.js. Sounds like thins goes wrong somehow. Check what is in node_modules/@vaadin/vaadin-usage-statistics after running npm run disable

[ankon]

Having the same issue, and did a bit of digging. Basically what seems to happen is this, assuming that node_modules doesn't exist in the beginning, and .npmrc contains settings for opting out.

1. @vaadin/vaadin-usage-statistics is installed, and runs postinstall (check.js)
2. check.js finds that collection is disabled, and renames vaadin-usage-statistics.js to vaadin-usage-statistics.js.bak, and then vaadin-usage-statistics-optout.js to vaadin-usage-statistics.js
3. "something" happens that runs @vaadin/vaadin-usage-statistics postinstall (check.js) again
4. check.js finds that collection is disabled, and renames vaadin-usage-statistics.js to vaadin-usage-statistics.js.bak ... and then fails to rename vaadin-usage-statistics-optout.js, because it doesn't exist anymore since step 2.

At this point the only thing you can do is remove node_modules/@vaadin/vaadin-usage-statistics and run npm install again.

IMHO this is a bug in @vaadin/vaadin-usage-statistics, it shouldn't rename the source files, but rather have a version for optin and optout, and copy the correct one onto the bare name.

For reproduction I tried this:

$ rm -rf node_modules/@vaadin/vaadin-usage-statistics/
$ npm install

> @vaadin/[email protected] postinstall /home/travis/build/.../node_modules/@vaadin/vaadin-usage-statistics
> node check.js


    You have disabled Vaadin development time usage statistics collection. To re-enable, run:
    npm explore @vaadin/vaadin-usage-statistics -- npm run enable
    For more details, see https://github.com/vaadin/vaadin-usage-statistics
  
added 1 package from 1 contributor in 9.347s
$ npm install
up to date in 8.557s
$ npm explore @vaadin/vaadin-usage-statistics -- npm run postinstall                                                

> @vaadin/[email protected] postinstall /home/travis/build/.../node_modules/@vaadin/vaadin-usage-statistics
> node check.js


    You have disabled Vaadin development time usage statistics collection. To re-enable, run:
    npm explore @vaadin/vaadin-usage-statistics -- npm run enable
    For more details, see https://github.com/vaadin/vaadin-usage-statistics
  
File not found!
$ ls /home/travis/build/Collaborne/collaborne-polaris-app/node_modules/@vaadin/vaadin-usage-statistics
check.js  LICENSE  package.json  README.md  vaadin-usage-statistics.js.bak

[ankon]

Looked further through our build logs, and found the "something": We run npm rebuild --update-binary whenever the NodeJS version changes to force updates to certain dependencies with native libraries, and that one does trigger a postinstall for everything.