branch id is not unique for subsequent REGISTRATION transactions about sipdroid

[GoogleCodeExporter]

Issue 149 has been merged into this issue.

Original comment by [email protected] on 2 Oct 2009 at 8:42

[GoogleCodeExporter]

anyone has a fix for this ??? I have added a patch to registerAgent.java
I am not sure the other message invite/subscribe should be treated same if 
authentication is reqired.



    private boolean processAuthenticationResponse(TransactionClient transaction,
            Message resp, int respCode){
        if (attempts < MAX_ATTEMPTS){
            attempts++;
            //xiaoyu add to make unique branch id
            Message req = transaction.getRequestMessage();
            req.setCSeqHeader(req.getCSeqHeader().incSequenceNumber());
            ViaHeader vh=req.getViaHeader();
            String  oldbranch=vh.getBranch();
            String  newbranch = SipProvider.pickBranch();
            vh.setBranch(newbranch);    
            android.util.Log.e("RegisterAgent","oldbranch="+oldbranch+" 
newbranch="+newbranch);
            req.addViaHeader(vh);
            if (handleAuthentication(respCode, resp, req)) {
                TransactionClient t = new TransactionClient
(sip_provider, req, this);

                t.request();
                return true;
            }
        }
        return false;
    }

Original comment by [email protected] on 4 Dec 2009 at 6:59

[GoogleCodeExporter]

I've added your patch to include it into next release.

Original comment by [email protected] on 11 Dec 2009 at 11:29

• Changed state: FutureRelease

[GoogleCodeExporter]

Original comment by [email protected] on 14 Dec 2009 at 8:54

• Changed state: Fixed

[GoogleCodeExporter]

Issue 290 has been merged into this issue.

Original comment by [email protected] on 21 Jan 2010 at 2:43