Wrong underlining of words starting with markup about ltex-ls

[ed359]

I wasn't using the tasks in tasks.json, so indeed that was the problem. Thank you for helping me run the tests. I'm on Windows and the build task fails with an error similar to the one described here: https://stackoverflow.com/questions/6347985/cannot-run-maven-using-mvn-d-argument-within-microsoft-powershell-but-works.

The issue is that powershell needs some quoting in the command string, namely '-Dmaven.test.skip=true' instead of -Dmaven.test.skip=true. If this change doesn't affect other OSes then it's probably a good idea in tasks.json.

[valentjn]

There is a bug in the computation of the length of the underlining (which also determines the word X in the message 'X': Possible spelling mistake found.). The checking itself is not affected (i.e., if you use a word LanguageTool knows, there won't be a diagnostic). The Use '...' quick fixes display the correct suggestions; however, the wrong word will be replaced when applying them. The Add 'X' to dictionary quick fix will add the wrong word (without the first letter) to the dictionary, but as the dictionary is compared against the underlined words, this will still result in the diagnostic to be resolved. The other quick fixes are working as intended.

[ed359]

Ok, it's good to know that the underlying spell checking is correct, but the user interface reporting 'X': Possible spelling mistake found. is where the error is. Thank you.

[valentjn]

Thanks for the report, this should be fixed.

[ed359]

The new tests in 6317adc do not pass for me:

[ERROR] Failures: 
[ERROR]   LatexAnnotatedTextBuilderTest.testMathMode:347 30 not smaller than 30 ==> expected: <true> but was: <false>
[ERROR]   LatexAnnotatedTextBuilderTest.testTextMode:207 expected: <0> but was: <5>
[ERROR]   DocumentCheckerTest.testLatex:182 expected: <?ekki> but was: <ekki>

[valentjn]

They pass in GitHub Actions (and for me), so it's definitely working.

Best guess is that you forgot to update your local installation of ltexls-languagetool-patch (see second task in .vscode/tasks.json).

[valentjn]

Fix released in 12.1.0.