Confirm whether slf4j, antlr, junit, jsontools dependencies are actually needed about validator

[jacobq]

I'm pretty sure they're not used in the WAR building code, but I'll plan to scan through the servlet code to see if slf4j is used. Personally, I'd like to leave that dependency there, but I also understand the desire to keep things lean and uncluttered. Unfortunately this week is super busy for me at work, but I've penciled some time on my calendar Saturday. I have a bad habit of letting requests rot though, so if a week goes by feel free to nag me and accept my apologies in advance :)

[sideshowbarker]

Hi @jacobq, OK and thanks for the reply—I'll plan to follow up with you next week. I'm not at all opposed to restoring the slf4j jar to the war package (and jar package too) but so far it's just not been clear to me in what other code and what other context that bundled sl4j code is actually ending up being used.

[cvrebert]

Upgrading slf4j to a more recent version would also be nice, if you're going to keep it around.

[sideshowbarker]

Upgrading slf4j to a more recent version would also be nice, if you're going to keep it around.

Agreed we should upgrade it if we keep it. But in two weeks of running without the slf4j dependency—both running a lot of tests locally and running without slf4j in the environment of the W3C validator (which processes on the order of at least 6 requests every second…), no errors due to the slf4j dependency have occurred. So as far as I can see, it's never getting exercised, so there's no point in restoring it.

[cvrebert]

Great! It was giving me grief when trying to use slf4j for application-level logging anyway 😄

[sideshowbarker]

Closing this, as it’s been a few weeks and no problems were reported.