GithubHelp home page GithubHelp logo

Comments (4)

tomaspanek avatar tomaspanek commented on June 15, 2024 2

Thanks, @brunoabude! Just submitted a pull request that would solve the timezone issues as you suggested.

from validator.js.

brunoabude avatar brunoabude commented on June 15, 2024 1

Looks like the Date constructor is now using the ISO8601 date format without the time zone offset info, which causes it to be interpreted as UTC+0 and can fail the comparison of .getDate() and the parsed day from the date string (which could be safely assumed to be in local time, i guess?)

To keep the same behaviour as the previous version, T00:00:00 could be concatenated to the isoformat, which will cause it to be interpreted as local time. As demonstrated here

return new Date(`${fullYear}-${dateObj.m}-${dateObj.d}`).getDate() === +dateObj.d;

from validator.js.

sacummings91 avatar sacummings91 commented on June 15, 2024

Can confirm this was breaking for us too. It was tricky to debug cuz it worked in our CI just fine but was failing locally. Rolling back to 13.9.0 for now to solve the issue until the fix goes in.

from validator.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.