GithubHelp home page GithubHelp logo

Comments (9)

akhra avatar akhra commented on September 20, 2024

Anecdotally, in testing the adjustment to our (admittedly still small) current codebase to each of Classy and RIO in isolation, the latter required less adjustment.

Would it be worthwhile to explore the option with a fork? (Should that fork be called Snickersnee, or Grayswandir? Only the most important questions, here.)

from magicbane.

valpackett avatar valpackett commented on September 20, 2024

Yeah, I saw RIO on various news link sites, it looks interesting I guess.

Magicbane was extracted from a Classy based application, but there's no actual reason to use one prelude over another here…

What about the option of not using custom preludes here? Honestly the only reason was that import Magicbane is the one and only import in the little demos, but that's silly. I'd totally accept a PR that replaces Classy with the regular base Prelude :)

from magicbane.

akhra avatar akhra commented on September 20, 2024

That'd just be a matter of not re-exporting it, right? And fixing the examples.

from magicbane.

akhra avatar akhra commented on September 20, 2024

I guess that would still force the dependency for people using another prelude. Still, it opens options and is a clean&easy first step.

from magicbane.

valpackett avatar valpackett commented on September 20, 2024

No, I mean completely removing it

from magicbane.

akhra avatar akhra commented on September 20, 2024

Fair enough, shouldn't be too much more work.

from magicbane.

akhra avatar akhra commented on September 20, 2024

99.9% done, examples/tiny.hs runs; examples/larger.hs is choking on:

No instance for (exceptions-0.8.3:Control.Monad.Catch.MonadMask
                         (MagicbaneApp LargeAppCtx))
        arising from a use of ‘timed’

Do you happen to have an insight on where that instance was coming from previously?

from magicbane.

akhra avatar akhra commented on September 20, 2024

For reference, here's where I'm at. The only thing that seems to be broken is the timed call, both in larger.hs and the second readme example. It doesn't seem to be due to the absence of ClassyPrelude tho, as I went ahead and imported it for the examples (and moved it to "recommended" in readme) so basically everything it provides should be there. I may have broken something in Magicbane.App?

from magicbane.

akhra avatar akhra commented on September 20, 2024

Strike that -- I just made a fresh clone of your repository and got the same errors. Not my fault! :P (Or, if my fault, something in tooling/environment, not code.) Gonna open the PR, further discussion there.

from magicbane.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.