Comments (9)
Anecdotally, in testing the adjustment to our (admittedly still small) current codebase to each of Classy and RIO in isolation, the latter required less adjustment.
Would it be worthwhile to explore the option with a fork? (Should that fork be called Snickersnee, or Grayswandir? Only the most important questions, here.)
from magicbane.
Yeah, I saw RIO on various news link sites, it looks interesting I guess.
Magicbane was extracted from a Classy based application, but there's no actual reason to use one prelude over another here…
What about the option of not using custom preludes here? Honestly the only reason was that import Magicbane
is the one and only import in the little demos, but that's silly. I'd totally accept a PR that replaces Classy with the regular base Prelude :)
from magicbane.
That'd just be a matter of not re-exporting it, right? And fixing the examples.
from magicbane.
I guess that would still force the dependency for people using another prelude. Still, it opens options and is a clean&easy first step.
from magicbane.
No, I mean completely removing it
from magicbane.
Fair enough, shouldn't be too much more work.
from magicbane.
99.9% done, examples/tiny.hs
runs; examples/larger.hs
is choking on:
No instance for (exceptions-0.8.3:Control.Monad.Catch.MonadMask
(MagicbaneApp LargeAppCtx))
arising from a use of ‘timed’
Do you happen to have an insight on where that instance was coming from previously?
from magicbane.
For reference, here's where I'm at. The only thing that seems to be broken is the timed
call, both in larger.hs
and the second readme example. It doesn't seem to be due to the absence of ClassyPrelude
tho, as I went ahead and imported it for the examples (and moved it to "recommended" in readme) so basically everything it provides should be there. I may have broken something in Magicbane.App
?
from magicbane.
Strike that -- I just made a fresh clone of your repository and got the same errors. Not my fault! :P (Or, if my fault, something in tooling/environment, not code.) Gonna open the PR, further discussion there.
from magicbane.
Related Issues (19)
- Call for Testing: No more ExceptT HOT 3
- Consider replacing ClassyPrelude with RIO (revisited) HOT 7
- Set a default User-Agent header when making Request objects HOT 3
- "instance HasModLogger a => HasLogFunc a" overlaps on bare LogFunc HOT 5
- Name conflict with RIO on fromString
- {instance (Default α) ⇒ DefConfig α} breaks things HOT 3
- Consider dropping Data.Has HOT 3
- Overlapping instances for HasLogFunc SimpleApp HOT 3
- Exception Handling HOT 2
- Example "larger.hs" doesn't compile in stack lts-12.21 HOT 5
- Conflicting exports for 'host' when building against latest wai-cli HOT 1
- magicbane-0.4.1 not found on Hackage HOT 1
- Unable to use with Servant Server 0.18.1 HOT 4
- Suggest changing license from UNLICENSE/public domain to BSD3 HOT 2
- Examples won't build in stackage LTS-9.0 HOT 4
- fails to build with either-5
- Poor type interaction with :<|> HOT 3
- magicbane-0.2.0 build failure with http-conduit-2.3 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magicbane.