migrating from make to cmake build toolchain about vamigaweb

[mras0]

Looks like the same issue I ran into here: dirkwhoffmann/vAmiga#611 (comment)

When compiling against the vAmigaCore library you need to ensure that you have the same feature flags defined (in this case, you probably need to define SCREEN_RECORDER). It's easier to keep in sync if everything is compiled with CMake, since the flags are automatically propagated (if they're PUBLIC at least).

[mithrendal]

I only took out the screenrecorder in the
Emulator/CMakeLists.txt

# Enable additional features on certain architectures
if(NOT WIN32)
#  target_compile_definitions(vAmigaCore PUBLIC SCREEN_RECORDER)
  target_compile_definitions(vAmigaCore PUBLIC GDB_SERVER)
endif()

which made it work ...

@mras0 thank you 😅 that was really fast and precise !👍

the next step will be to learn now how to integrate the mainsdl.cpp also with cmake. I have to look some tutorials first about cmake I bet...😅

[dirkwhoffmann]

you probably need to define SCREEN_RECORDER

Oh yes, that makes sense. I should merge in the Windows code for the screen recorder asap. Once this is done, we don't have to take care about different feature sets any more.

[mithrendal]

It's easier to keep in sync if everything is compiled with CMake

@mras0

I am completely new to cmake and had first some trouble to get it running with emscripten toolchain ... after hours of studying it I deleted all previously handmade makefiles 😎 and now we have a result which I am very happy with🙃 ... ... nevertheless would you mind to have a look on it and do some code review ? Escpecially the base CMakeLists.txt

to build and run vAmigaWeb locally, the following command sequence is now necessary

mkdir build
emcmake cmake -S . -B build
cd build 
make
make run

start a web browser and head to localhost:8080

[mras0]

Looks good to me 👍

Optionally you may want to add DEPENDS vAmiga to your custom targets (run/publish) to make sure you have the latest version and can always just run make run.

I'd probably also create a .gitignore file for build, index.html, vAmiga.js and vAmiga.wasm.

[mithrendal]

@mras0 that's great now we can just call make run and everything is being build automatically 😎

mkdir build
emcmake cmake -S . -B build
cd build 
make run

start a web browser and head to localhost:8080

or without using make

mkdir build
emcmake cmake -S . -B build
cd build 
cmake --build . --target run

start a web browser and head to localhost:8080

I also added the generated files to .gitignore as you said ....👍