GithubHelp home page GithubHelp logo

Comments (5)

vanderlee avatar vanderlee commented on May 27, 2024

Age of the english file isn't necessarily an issue. If the -de file is deprecated, then for backwards compatibility sake it would be best to either duplicate (easy fix) the replacement or have some internal mapping (clean fix) of "de" to whichever version should be considered the "official" language (I'm guessing de-1996?).

from phpsyllable.

alexander-nitsche avatar alexander-nitsche commented on May 27, 2024

Yes, hyph-de-1996 would be the official up-to-date one.

from phpsyllable.

vanderlee avatar vanderlee commented on May 27, 2024

I can't really think of a good solution here beyond making an exceptional case of this in \Vanderlee\Syllable\Source\File::loadLanguage. If you agree, I'll just add some type mapping which will take effect if no actual language file is present. And also remove hyph-de.tex from the repo.

from phpsyllable.

alexander-nitsche avatar alexander-nitsche commented on May 27, 2024

We can work with the existing solution by using the same remote URL for fetching hyph-de-1996.tex as well as hyph-de.tex. The drawback is to provide the same file content via two filenames, but i would prefer that over a hardcoded extra rule for German. What do you think?

from phpsyllable.

vanderlee avatar vanderlee commented on May 27, 2024

Resolved in #63

from phpsyllable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.