CI build broken with 0.9.0: Cannot perform signing task ':signArchives' because it has no configured signatory about gradle-maven-publish-plugin

[gabrielittner]

When we turn off legacy mode by default it will help everyone. It's just Android that's blocking it right now

[gabrielittner]

@akarnokd 0.10.0 should work for you again without having to configure anything

[gabrielittner]

I'll take a look later today, thanks for reporting it

…

On Mon, 10 Feb 2020, 11:10 David Karnok, ***@***.***> wrote: After bumping the plugin version to 0.9.0, all my project builds on CI is broken. For example, https://github.com/akarnokd/RxJavaExtensions/pull/51/files . I don't use CI to deploy the artifacts and with 0.8.0, it was expectedly saying <https://travis-ci.org/akarnokd/RxJavaExtensions/builds/640798449#L205> :signArchives SKIPPED. Is there a new settings to skip signing in case of missing keys on CI? $ ./gradlew assemble Starting a Gradle Daemon, 1 incompatible and 1 stopped Daemons could not be reused, use --status for details > Task :compileJava > Task :processResources NO-SOURCE > Task :classes > Task :jar > Task :signArchives FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':signArchives'. > Cannot perform signing task ':signArchives' because it has no configured signatory * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org https://travis-ci.org/akarnokd/RxJavaExtensions/builds/648234157#L202 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#114?email_source=notifications&email_token=AAKLSGLDE6RYWKF6E67KULDRCER2RA5CNFSM4KSLFLV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IMGL5XQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKLSGJMZW3GMMTFVI3V6L3RCER2RANCNFSM4KSLFLVQ> .

[vanniktech]

Have you tried?

mavenPublish {
  releaseSigningEnabled = false
}

[akarnokd]

Wouldn't that disable signing when I do want to release from my local build?

[gabrielittner]

This is caused by removing our hacky onlyIf in #101 which was checking if there are any upload tasks in the task graph.

There is a gradle property you can set for releaseSigningEnabled. It's called RELEASE_SIGNING_ENABLED. You can set it to false in the committed gradle.properties in your repo and then set it to true in the same place where you set the signing properties on your local machine. Does that work for you?

[akarnokd]

I only want the plugin to sign the jars when I call uploadArchives. Every other case, CI or local machine, should not sign them. 0.8.0 worked so far thus I otherwise don't really need to update right now.

[gabrielittner]

I did a quick check and Gradle seems to do the right thing when using maven-publish. So setting

mavenPublish {
	useLegacyMode = false
}

should do what you want (for Android projects this requires Android Gradle Plugin 3.6.0).

Another alternative would be setting RELEASE_SIGNING_ENABLED to false in your repo and when you publish you run uploadArchives -PRELEASE_SIGNING_ENABLED=true.

[vanniktech]

Is there anything else that we need to do here?

[gabrielittner]

I don't think so. The only thing we could do as adding back the hack we had before for legacy mode, but I'd like to avoid that and there are work arounds through properties. With AGP 3.6.0 stable being very close I'd just leave it and then we can disable legacy mode by default for the correct behavior.

[akarnokd]

I'll stay on 0.8.0 for now.

[vanniktech]

I don't think David is using the Android Gradle Plugin though. So that would not help him

[vanniktech]

We can close this given that #120 was merged, right?

[gabrielittner]

Yes