GithubHelp home page GithubHelp logo

Comments (7)

vanniktech avatar vanniktech commented on August 16, 2024

Yep sounds about right. I personally haven't had a user case for taking the project.version.

from gradle-maven-publish-plugin.

benasher44 avatar benasher44 commented on August 16, 2024

In some of the IntelliJ project templates, project.version comes preset, which is how our team got to using/relying on it. Do you think it could make sense to accommodate that in this plugin somehow? Depending on your CI setup, there are good reasons to specify your version at configure time in gradle code.

from gradle-maven-publish-plugin.

vanniktech avatar vanniktech commented on August 16, 2024

Yeah. I'm thinking if project.version is set take it, otherwise VERSION_NAME. What do you think @gabrielittner ?

from gradle-maven-publish-plugin.

gabrielittner avatar gabrielittner commented on August 16, 2024

We could also just use project.version when configuring the pom. When the plugin is applied we immediately set project.version to VERSION_NAME https://github.com/vanniktech/gradle-maven-publish-plugin/blob/master/src/main/kotlin/com/vanniktech/maven/publish/BaseMavenPublishPlugin.kt#L27
If we continue using project.version after that, instead of reading VERSION_NAME again it becomes overridable in build file.

from gradle-maven-publish-plugin.

vanniktech avatar vanniktech commented on August 16, 2024

Then let's do that.

from gradle-maven-publish-plugin.

gabrielittner avatar gabrielittner commented on August 16, 2024

@benasher44 Your overridden project.version will be used in 0.10.0.

from gradle-maven-publish-plugin.

benasher44 avatar benasher44 commented on August 16, 2024

Thanks!!

from gradle-maven-publish-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.