Support for Dokka about gradle-maven-publish-plugin

[ZacSweers]

I'll take a crack at this

[saket]

I'll try sending a patch this weekend.

[vanniktech]

Sure, want to take a stab at it?

[saket]

That's what I initially wanted to try, but I'm quite bad at build tools. Would you be okay if I send potentially buggy patch and help me understand how things work?

[digitalbuddha]

Not sure if its the proper way but here's how I did it in the past https://github.com/NYTimes/Store/search?utf8=%E2%9C%93&q=dokka&type=

[vanniktech]

Don't have too much time currently but yes let's try to figure out a solution.

[saket]

Hey @vanniktech, just wanted to let you know that I tried my hands on this twice but failed terribly. Being new to Groovy and Gradle plugins, I found myself lost in the syntax. Based on @hzsweers's implementation in AutoDispose, here's what I could come up with so far:

https://github.com/saket/gradle-maven-publish-plugin/blob/master/src/main/groovy/com/vanniktech/maven/publish/MavenPublishPlugin.groovy#L74

I wasted a lot of time trying to find a short feedback loop. I tried writing tests, but that didn't work out well.

[gabrielittner]

@saket fyi when #35 is merged you could implement the support in Kotlin by just adding those as additional if cases before the existing

gradle-maven-publish-plugin/src/main/kotlin/com/vanniktech/maven/publish/BaseMavenPublishPlugin.kt

Lines 29 to 33 in e774a18

	if (project.plugins.hasPlugin("com.android.library")) {
	setupConfigurerForAndroid(project, configurer)
	} else {
	setupConfigurerForJava(project, configurer)
	}

You run into way less weird syntax or typing issues then.

Edit: it's merged now.

[vanniktech]

Yup also believe this should be easier now. Will also try to have a look at this next week.

[saket]

@gabrielittner that looks much nicer

[Egorand]

Any updates on this?

[Egorand]

Any progress on this?

On a side note, kinda frustrated by the amount of support this library is getting, thinking about switching back to custom Gradle files.

[vanniktech]

Have you had time to check out the PR and see whether it worked for you or not?

I've just realized that I mentioned the wrong Egor on the PR. Sorry for that and fixed it now.

[Egorand]

Oh, found it, thanks. I'll review.