Add logic for only compressing certain content types about gzip-provider

[tanner0101]

That's interesting. As long as the middleware is applied late enough in the chain we should have content-type information in the headers to help make this decision.

[czechboy0]

Hmm, is there a middleware which sees the response but can't see the content type yet? I thought the routes always return a fully defined response. But yeah, we can always choose a sane default (to not gzip unless we know the content type and it's a well compressible one)

[tanner0101]

If the response has var json: JSON? set, but hasn't gone through the JSONMiddleware yet, then it would appear the response is empty. The JSONMiddleware is what serializes the JSON to the body and sets the appropriate headers, Content-Length, Content-Type etc. And there are other middlewares that work like this, so gzipping would need to be toward the end of the line.

[czechboy0]

Yeah, makes sense. I guess we'd just need to document how to add that
middleware. Works for me great, I'd like to see more people gzipping soon.
On Mon, Aug 22, 2016 at 6:06 PM Tanner [email protected] wrote:

If the response has var json: JSON? set, but hasn't gone through the
JSONMiddleware yet, then it would appear the response is empty. The
JSONMiddleware is what serializes the JSON to the body and sets the
appropriate headers, Content-Length, Content-Type etc. And there are
other middlewares that work like this, so gzipping would need to be toward
the end of the line.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACFL6bQu2lbW6naMHMn3gkmBmr40Pwfqks5qickjgaJpZM4Jp5TC
.