GithubHelp home page GithubHelp logo

Tweaks to marks and matches cache about klogg HOT 3 CLOSED

variar avatar variar commented on June 23, 2024
Tweaks to marks and matches cache

from klogg.

Comments (3)

gin-ahirsch avatar gin-ahirsch commented on June 23, 2024

Note that the commit have been updated. It's best to follow this branch: https://github.com/gin-ahirsch/glogg/commits/eager-filtered-items-cache.

from klogg.

gin-ahirsch avatar gin-ahirsch commented on June 23, 2024

I have started porting my changes to klogg.
I have one issue at the moment: https://github.com/gin-ahirsch/glogg/blob/4ac06ca0d198b0773f2ad81beace333d9695df02/src/logdata/src/logfiltereddata.cpp#L359
I've changed LogFilteredDataWorkerThread::getSearchResult() to LogFilteredDataWorkerThread::updateSearchResult(), which instead of copying the whole array only appends the missing elements. Since in glogg the array is updated linearily this is trivial. I assume that the multi-threaded search feature of klogg means that the updates can also happen out of order, so obviously that breaks.
I want to try and change LogFilteredDataWorkerThread to not sort the array at all and just append to the end, so LogFilteredData can do the sorting in its place, which will allow the update and indexing for the eager filteredItemsCache_ to work as I intended.

It's possible that I don't get the time to work on this until mid-April, so I wanted to drop this note here.

from klogg.

gin-ahirsch avatar gin-ahirsch commented on June 23, 2024

The port is now complete and functional at https://github.com/gin-ahirsch/glogg/tree/eager-filtered-items-cache-klogg. I'll open a PR once #67 is merged, since the branch builds on those changes.

from klogg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.