Compile error on macOS ARM64 Apple Silicon about goldendict

[vedgy]

Have you tried merging #1 locally?

[glowinthedark]

@vedgy:

Have you tried merging #1 locally?

Nice! wasn't aware of that pr! Didn't try yet.

What I did was replace all the binary libs with arm64 flavours, i.e. with something the following

rm -rf maclibs/lib/*
cp -L /opt/homebrew/lib/libhunspell-1.7.0.dylib maclibs/lib
cp -L /opt/homebrew/Cellar/libiconv/1.17/lib/libiconv.dylib maclibs/lib
cp -L /opt/homebrew/lib/libogg.dylib maclibs/lib
cp -L /opt/homebrew/lib/liblzo2.dylib maclibs/lib
cp -L /opt/homebrew/lib/libtiff.dylib maclibs/lib
cp -L /opt/homebrew/lib/liblzma.dylib maclibs/lib
cp -L /opt/homebrew/lib/libopencc.dylib maclibs/lib
cp -L /opt/homebrew/lib/libzstd.a maclibs/lib
cp -L /opt/homebrew/Cellar/libao/1.2.2/lib/libao.dylib maclibs/lib
cp -L /opt/homebrew/Cellar/ffmpeg/6.0_1/lib/libavcodec.dylib maclibs/lib
cp -L /opt/homebrew/Cellar/ffmpeg/6.0_1/lib/libavformat.dylib maclibs/lib
cp -L /opt/homebrew/Cellar/ffmpeg/6.0_1/lib/libavutil.dylib maclibs/lib
cp -L /usr/local/lib/libeb.dylib maclibs/lib
cp -L /opt/homebrew/Cellar/hunspell/1.7.2/lib/libhunspell-1.7.dylib maclibs/lib
cp -L /opt/homebrew/lib/liblzma.a maclibs/lib
cp -L /opt/homebrew/Cellar/opencc/1.1.6/lib/libopencc.dylib maclibs/lib
cp -L /opt/homebrew/lib/libswresample.4.dylib maclibs/lib
cp -L /opt/homebrew/lib/libvorbisfile.3.dylib maclibs/lib
cp -L /opt/homebrew/lib/libvorbis.dylib maclibs/lib
mkdir -p maclibs/lib/ao
cp -L /opt/homebrew/Cellar/libao/1.2.2/lib/ao/plugins-4/libmacosx.so maclibs/lib/ao

Replacing x64 libs with the arm64 libs + adjusting the file names made the build compile just fine.

[glowinthedark]

@vedgy: With #1 there are compiler version errors with Xcode 15.0.1 (macos sdk 14.0); this might be related to https://stackoverflow.com/a/70778475/191246

compiler log: https://pastebin.com/2XR315fd

[vedgy]

compiler log: https://pastebin.com/2XR315fd

error "Qt requires a C++17 compiler"

Qt 5 requires C++11 or later. Qt 6 requires C++17 or later. GoldenDict does not support Qt 6 yet. Make sure to build against Qt 5.

[glowinthedark]

@vedgy:

Make sure to build against Qt 5.

as mentioned in the original description, in both cases the command was the same:

/opt/homebrew/Cellar/qt@5/5.15.10_1/bin/qmake "CONFIG+=release no_epwing_support sdk_no_version_check use_qtwebengine no_ffmpeg_player" QMAKE_APPLE_DEVICE_ARCHS="arm64" goldendict.pro
make -j 12

this does work fine with the master branch (after replacing the dylibs), but the same command fails with code from pr #1 — looks to me like it's something wrong with the config in goldendict.pro

[vedgy]

Maybe this part of the diff in #1 is at fault:

+    INCLUDEPATH += /opt/homebrew/include
+    LIBS += -L/opt/homebrew/lib -framework AppKit -framework Carbon

See also the pull request's changes to README.md. An extract:

NOTE: The current version of qt is Qt6, which I've been unable to compile successfully. So you either not to install the qt package, but install qt@5 or do the following:

brew unlink qt && brew link qt@5

[glowinthedark]

@vedgy: Yes, that was indeed the root cause! — I had both qt@5 and qt (6) installed. after brew rm qt the compilation with #1 succeeded. Thanks!