Comments (4)
The solution to this issue will be implemented like the rocket
crate: by defining feature-flagged macros that reexport the existing macros from log
if the feature is active, and do nothing otherwise.
from hudhook.
That's a great idea, thank you. General refactoring is already planned for a new minor release sometime in the near future, so this could very well be part of that.
from hudhook.
Decided to postpone this too for a later release because the implementation resulted quite tricky and I don't want to invest too much energy on it right now.
I leave a sketch of a possible solution here. It doesn't compile, tries to cloak the macros but it results in some weird scoping issues. I'd consider an alternative solution, if possible.
from hudhook.
Now that we have tracing
, this might not be necessary and in fact could be dealt with by just setting up the subscribers.
@Jakobzs, you have worked on tracing
, do you know how these two could be achieved and if my hypotheses are correct?
- Completely suppress logging (hypothesis: if you just don't depend on
tracing-subscriber
in your client, you don't pay any of the runtime cost of having tracing macros?) - Filtering out all messages coming from
hudhook
(do some filtering when setting uptracing-subscriber
on the client -- do you have a snippet of what this could look like?)
from hudhook.
Related Issues (20)
- Automated testing harness
- Add performance metrics
- Bump to `windows` 0.53
- Write a coobook
- An issue with version 0.6.5 HOT 8
- Support uploading images of any width HOT 1
- DX8 HOT 2
- Question about loading and using font HOT 3
- Plan for 0.7 HOT 4
- Backend assertion failure (possibly from wrong mouse event handling) HOT 12
- need ways to filter certain windows message, without blocking everything HOT 1
- hudhook pipeline doesn't report `delta_time` to imgui runtime HOT 1
- Bump imgui-rs to 0.12
- index out of bounds error when loading texture using new RenderContext API (DX9) HOT 2
- Unexpected DirectX9 behavior HOT 5
- loading more then 8 textures doesn't work HOT 2
- RivaTuner overlay conflict HOT 4
- DXGIGetDebugInterface not available on some platforms
- Switch to std `LazyLock` / `LazyCell`
- Add support for add_text to pass font size as param HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hudhook.