[Feature Request] Allow interchangeable use of stream types by exposing ImplFtpStream about suppaftp

[veeso]

That's a good point. Made it public in 5.1.1

[veeso]

Probably a trait would be needed, but it's not that easy to implement here.

Anyway at the time I didn't think much about your request, but there's no need to use the plain FTP stream if secure is enabled. You can just use the RustlsFtpStream or NativeTlsFtpStream and call into_secure only if secure = true

[svet-b]

Thanks a lot for the quick response to this! I had a go at doing what I need to do with the new version but somehow didn't quite get it to work. I'm sure this will expose my ignorance when it comes to some Rust concepts, but since ImplFtpStream is actually a struct and not a trait, I'm not able to use it as a dyn type.

Is there a way to write code that will set up an ftp_stream that is generic over ImplFtpStream (regardless of whether the encapsulated stream is secure or not) and can then carry out the login() and other methods that are common to both types of connection? Sorry if I'm missing something simple...

[svet-b]

FWIW I wrote a bit about my attempts to do this, and got some advice on the user forum here: https://users.rust-lang.org/t/more-elegant-way-to-call-generic-methods-on-a-struct/92397

[svet-b]

Oh wow, that's a very good point! Didn't occur to me to try that at all. Seems to work perfectly also.