Comments (9)
This is a good idea indeed. Can you make a PR on this one?
from swiftpasscodelock.
I could try. But i'm not sure what is the best implementation from architectural point of view. Probably new protocol for such behaviour or maybe just parameter in PasscodeLockConfigurationType.
from swiftpasscodelock.
I would think it fits nice in PasscodeLockConfigurationType
:)
from swiftpasscodelock.
What do you think of PR #28.
Adding it in PasscodeLockConfigurationType
will not be backward compatible :)
from swiftpasscodelock.
- I think that passcodeLockWindow windowLevel is not enough. Other libraries could change main windowLevel too. And to be in sync it may be better to setup main windowLevel, passcodeLockWindow behind windowLevel and passcodeLockWindow at the front windowLevel;
- To maintain backward compatibility default protocol extension could be made. Or new configuration type probably. Not sure which is better.
from swiftpasscodelock.
I am not so familiar with regards using many windows.
Can you make a PR please with what you think as better?
Thanks a lot for trying to make this library better :)
from swiftpasscodelock.
Yes, i'll do. Just have not time for it right now. Will try on next week.
from swiftpasscodelock.
Thank you
Sent from my iPhone
On 13 ???? 2016, at 01:03, asfdfdfd <[email protected]mailto:[email protected]> wrote:
Yes, i'll do. Just have not time for it right now. Will try on next week.
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/25#issuecomment-225463216, or mute the threadhttps://github.com/notifications/unsubscribe/AAw_jKMRqxK7OiSkiTA4GEF_vOl6KFdbks5qLIIRgaJpZM4IvS00.
from swiftpasscodelock.
Here it is: #37
from swiftpasscodelock.
Related Issues (20)
- Keychain support (originally: Suggestion) HOT 6
- Landscape view? HOT 2
- License HOT 2
- Correct typos HOT 1
- deletePasscode() Not Getting Called. HOT 3
- App switcher screenshot HOT 1
- Can't set TouchId reason at runtime
- Touch ID misbehaviour HOT 3
- inccorectPasscodeAttempts value not persisted between app launches HOT 3
- Could not build PasscodeLockDemo
- cancelable TouchId prompt when restoring the app from background HOT 2
- Swift 3 update HOT 4
- Cannot install via carthage / Xcode 8.3.1 into Swift 3 Project HOT 2
- no 1.0.3 version available HOT 3
- Use of UIApplication.shared prevents usage within ios extensions HOT 5
- mainWindow's windowLevel should not be changed HOT 1
- dismissPasscodeLock(animated: Bool = true) called many times? HOT 1
- PasscodeLockPresenter not showing passcode screen
- Swift 4.2 Support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftpasscodelock.