GithubHelp home page GithubHelp logo

Comments (9)

ziogaschr avatar ziogaschr commented on June 23, 2024

This is a good idea indeed. Can you make a PR on this one?

from swiftpasscodelock.

asfdfdfd avatar asfdfdfd commented on June 23, 2024

I could try. But i'm not sure what is the best implementation from architectural point of view. Probably new protocol for such behaviour or maybe just parameter in PasscodeLockConfigurationType.

from swiftpasscodelock.

ziogaschr avatar ziogaschr commented on June 23, 2024

I would think it fits nice in PasscodeLockConfigurationType :)

from swiftpasscodelock.

ziogaschr avatar ziogaschr commented on June 23, 2024

What do you think of PR #28.
Adding it in PasscodeLockConfigurationType will not be backward compatible :)

from swiftpasscodelock.

asfdfdfd avatar asfdfdfd commented on June 23, 2024
  1. I think that passcodeLockWindow windowLevel is not enough. Other libraries could change main windowLevel too. And to be in sync it may be better to setup main windowLevel, passcodeLockWindow behind windowLevel and passcodeLockWindow at the front windowLevel;
  2. To maintain backward compatibility default protocol extension could be made. Or new configuration type probably. Not sure which is better.

from swiftpasscodelock.

ziogaschr avatar ziogaschr commented on June 23, 2024

I am not so familiar with regards using many windows.
Can you make a PR please with what you think as better?

Thanks a lot for trying to make this library better :)

from swiftpasscodelock.

asfdfdfd avatar asfdfdfd commented on June 23, 2024

Yes, i'll do. Just have not time for it right now. Will try on next week.

from swiftpasscodelock.

ziogaschr avatar ziogaschr commented on June 23, 2024

Thank you

Sent from my iPhone

On 13 ???? 2016, at 01:03, asfdfdfd <[email protected]mailto:[email protected]> wrote:

Yes, i'll do. Just have not time for it right now. Will try on next week.

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/25#issuecomment-225463216, or mute the threadhttps://github.com/notifications/unsubscribe/AAw_jKMRqxK7OiSkiTA4GEF_vOl6KFdbks5qLIIRgaJpZM4IvS00.

from swiftpasscodelock.

asfdfdfd avatar asfdfdfd commented on June 23, 2024

Here it is: #37

from swiftpasscodelock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.