GithubHelp home page GithubHelp logo

Comments (4)

yasserlens avatar yasserlens commented on June 18, 2024 1
  1. Done - #111
  2. The final error message will depend on each store (depends on what the error is), but in general, a "An error occurred, could not do XYZ" would help even if only as console.log messages. In our case, it was the attempts to fetch entities. We'd like to solve this by returning the errors object from the response.json() output in api.ts.

from storefront-qwik-starter.

gioboa avatar gioboa commented on June 18, 2024

Thanks for your feedback.

  1. this is a nice improvement, pls open a PR for that
  2. which kind of error need to be exposed to the end user?
    If we have a status code we can translate it in various languages

from storefront-qwik-starter.

yasserlens avatar yasserlens commented on June 18, 2024

I tried to fix #2 with the following pull request:
#112

This works so far for me locally. Let me know if it doesn't make sense. I haven't tested this thoroughly.

from storefront-qwik-starter.

gioboa avatar gioboa commented on June 18, 2024

Thanks for your PR, it looks good

from storefront-qwik-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.