GithubHelp home page GithubHelp logo

Comments (5)

gioboa avatar gioboa commented on June 2, 2024

Can you attach a gif to show the problem pls?

from storefront-qwik-starter.

msj121 avatar msj121 commented on June 2, 2024

@gioboa Sure, the issue also applies to default store. Top image you can see the main load screen with bar at top

Screen Shot 2023-07-19 at 3 16 31 PM

Here you can see as you scroll there is no header that sticks (ie: like fixed position), I can see the tailwind class for sticky, but it is not working:

Screen Shot 2023-07-19 at 3 16 46 PM

header has class="bg-gradient-to-r from-blue-700 to-indigo-900 transform shadow-xl sticky top-0 z-10 animate-dropIn"

from storefront-qwik-starter.

gioboa avatar gioboa commented on June 2, 2024

I see, thanks for the feedback. I will investigate in it

from storefront-qwik-starter.

msj121 avatar msj121 commented on June 2, 2024

Ok - solved it - I will make a pull request. Just trying to touch up the design because I am not sure I am a fan yet.

Solution: the "class" on header needs to be moved to its parent div like this:

<div class="sticky top-0 left-0 right-0 bg-gradient-to-r from-blue-700 to-indigo-900 transform shadow-xl sticky top-0 z-10 animate-dropIn">
			<header>
				<div... 

Nvm.. that messes up the cart. Ok, cart needs to be moved to "layout" after header.

from storefront-qwik-starter.

msj121 avatar msj121 commented on June 2, 2024

@gioboa Okay I made a PR where I did some quick checking it works. Not sure if design wise it is what you want but here is a snapshot below:

I did mention in PR, is there a way to "resize" or change "classes" on scroll using qwik. I will have some javascript that watches window scroll event, and if not top of the page I can set a signal to true and change classes, but I don't want to cause inefficient code with qwik. Any advice?

Screen Shot 2023-07-19 at 6 07 41 PM

from storefront-qwik-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.