Multiple database queries when using userResponsible about revisionable

[duellsy]

currently no, open to pull requests on the dev branch for this though, sounds handy

[SuperlativeEntity]

+1

[mmodler]

+1

Why closed?

[duellsy]

Closed since nobody decided it was important enough to work on, will re-open so someone can work on this and submit a pull request

[mmodler]

My workaround for now in my Basemodel:

public function revisionHistoryWithUser()
{
    return $this->morphMany('\MyAppName\Models\Revision', 'revisionable')->with('user');
}

[carcinocron]

Is there a reason this doesn't work? (from Laravel docs)

$books = Book::all();

$books->load('author', 'publisher');

[warksit]

Just to expand slightly on @mmodler response as it did lead me in the right direction.

Create a Revision class of your own extending \Venturecraft\Revisionable\Revision.
Add a true user relation:

    public function user(){
        return $this->belongsTo('User'); //Namespace as appropriate
    }

then add function revisionHistoryWithUser() as @mmodler said
If you already have your view set up remember to now reference user rather than userResponsible.

@InstanceOfMichael I don't believe that will work as userResponsible is not defined as a relationship of Revision.

[carcinocron]

That seems likely, I think defining that use relationship was probably one of the first things I did.

[pr4xx]

+1

[mavci]

+1

[cuberinooo]

as @warksit pointed it out. You can make it more simple just by using the relation.

Extends Revision and put the following code:

public function user(){ return $this->belongsTo(User::class); }

In your application you can use it like $revision->user instead of $revision->userResponsible(). And just as relations you can do your eager load as you would do with eloquent models.
Btw if you load your revisions: do it like Revision::with(['revisionable','user'])