GithubHelp home page GithubHelp logo

Comments (5)

igorklopov avatar igorklopov commented on May 12, 2024 1

No, it will be backported to all supported versions of Node.js. That is why the patch is 'draft'.

from pkg.

igorklopov avatar igorklopov commented on May 12, 2024

Will be eventually fixed by vercel/pkg-fetch@85ce383 released.

from pkg.

devinivy avatar devinivy commented on May 12, 2024

Out of curiosity, will that require using node v7 with pkg?

from pkg.

devinivy avatar devinivy commented on May 12, 2024

Hey @igorklopov I'm finding that this fix doesn't quite follow spec. While Class.toString() no longer errors, it returns a slightly incorrect value. Should I open a new issue for this?

const A = class {};
console.log(A.toString());
// Outputs : "function A() { [native code] }"
// Expected: "class {}"

For more details on the spec, see https://stackoverflow.com/a/30760236.

from pkg.

igorklopov avatar igorklopov commented on May 12, 2024

Agreed. Reopening and renaming (to keep valuable conversation).

from pkg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.