Comments (8)
Appreciate the feedback, folks. Have a smaller PR here to better surface the "active" tasks to the top of the list: #8632
This doesn't necessarily answer to everything shared above but a small step forward.
from turbo.
Limitations of terminal rendering aside (a big aside, I know!) my inclination would be to have the sidebar scroll to show the current running tasks.
Thinking through use cases, there are possibly three different views I'd prefer:
- For CLI and other places we're writing to a log, you'd use the traditional view
- For jobs that have interactivity or run indefinitely the current new UI
- For local jobs that are not interactive and have a definite end, a progress-based UI which doesn't currently exist.
IIRC an early version of the new UI had a progress bar. I imagine it was removed due to space concerns.
Anyway, I want to reiterate that I love the great work you're all doing here! These are just my suggestions and not complaints.
from turbo.
I've had this happen to me as well but couldn't strictly decide what would be "better"?
Trying to bake down this feedback into actionables, what heuristic would you think makes the most sense for the list? What "belongs" at the top? What "belongs" at the bottom? Are there situations where you would want those heuristics to flip?
I think I've formulated my opinion on what an improved list order would look like, but want to hear your opinion first.
from turbo.
Adding my experience with the new layout and the reasons I ultimately switched back to the old (streaming) output. Also want to stress that these aren't complaints but just personal preferences that made me decide the new shiny layout wasn't worth it for me:
- I immediately missed the ability to use the terminal buffer to scroll back or search.
- Since the new layout is always sending output to the terminal (via the spinner, etc.) it messed with my terminal's status indicator (screenshot below) so if I had the tab in the background I never actually knew if there was "real" output or not.
Showing the spinner that never goes away with the new layout:
from turbo.
it would benefit to actually explain the task list order, because currently, it looks random
can you also update the task list checkmark to show cache hit/miss?
miss for green check
hit for blue check
from turbo.
can you also update the task list checkmark to show cache hit/miss?
This is on our minds but not sure yet how we want to implement. I'm not sure that blue/green is enough since a) color alone is not enough for colorblind users and b) blue/green doesn't inherently carry that meaning of "hit/miss". We'll be able to think of something to express this surely, just not sure what yet.
from turbo.
We just shipped a refactor in 2.0.7 (#8650) that puts in-progress tasks at the top of the list, which it appears addresses the issues of the original Issue comment.
I do see other bits of feedback here in the comments (and some side-feedback in original) that are also things on our mind as we continue to iterate. If anyone feels strongly enough that you feel a separate Issue is worth creating, we're happy to take those on as well.
Thank you!
from turbo.
Would you consider letting the user provide a custom fn, I'll open an issue for this if it is viable.
({name,cacheHit,type})=>fn(...)
name: name of the task
cacheHit: boolean
status: "fail"|"success"|"running"|"long running"
from turbo.
Related Issues (20)
- 2.0.10+ doesn't keep the dev command open HOT 1
- Watch-mode running too often when turborepo is set up inside a folder HOT 6
- Downgrade issue - bun/yarn HOT 1
- `prune` gives OS privilege error HOT 1
- 'INCLUDE_VUE' ...Finishing writing to cache... Oops! Turbo has crashed. HOT 1
- StyledComponents config should allow empty topLevelImportPaths & meaninglessFileNames array HOT 2
- svg with fragment not support HOT 4
- Development not running in interactive mode HOT 2
- Keypress interaction with `vite` doesn't work ("o"+Enter doesn't open web) HOT 1
- Support pnpm.ignoreOptionalDependencies when pruning lockfile
- turbo 2.0.10 prints turbo version to stderr breaking CI pipeline HOT 4
- create-turbo not working HOT 2
- Docs: Registering Root Tasks - Incorrect/Unclear example
- Misleading example in multi-language support docs
- Yarn 4: Respect `enableTransparentWorkspaces: false` when resolving workspace dependencies HOT 1
- Turbo `v2.0.10-canary.1` and newer - port forwarding stopped working (`v2.0.10-canary.0` and older is fine) HOT 1
- Docs: Add any recommendations on how to manage cache using Just-In-Time packages. HOT 1
- Issue while reading "/home/user/repo/.npmrc". Failed to replace env in config: ${NODE_AUTH_TOKEN} HOT 1
- [Linux] `turbo watch *` very often results in `discovery failed: bad grpc code`/`channel closed` error messages
- Docs: Docs is down, just returns a 404 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turbo.