GithubHelp home page GithubHelp logo

Comments (12)

stepcheunghk avatar stepcheunghk commented on May 24, 2024 2

@ioolkos Hi! I Have been working on other projects recently. Didn't have time to take a deep look at it.
I will spend some time on it and get back to you later.

from vernemq.

ioolkos avatar ioolkos commented on May 24, 2024

@stepcheunghk RocksDB is not "compiled in" in 1.13.0.

If you want to reconcile branches and look into this, use:
https://github.com/vernemq/vernemq/tree/new-feature-rocksdb-messagestore

It's straightforward to build a Verne-RocksDB release. The only thing is that the RocksDB settings are currently not exposed to the vernemq.conf file, so you have to do all RocksDB configuration in the advanced.config file. I'm starting to think that this is okay or even preferable. (I viewed it as a blocking issue in the past).


👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

stepcheunghk avatar stepcheunghk commented on May 24, 2024

Hello Sir @ioolkos, thank you for your prompt response ! Let me have a look first.

from vernemq.

ioolkos avatar ioolkos commented on May 24, 2024

@stepcheunghk (since you closed the issue): keep us posted about any findings, in case you test or work on the branch.
At some point, we might also just merge the branch, it's really just adding & not touching other stuff.


👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

stepcheunghk avatar stepcheunghk commented on May 24, 2024

Sure. Thanks for your help. Will let you know if there is any finding.

from vernemq.

stepcheunghk avatar stepcheunghk commented on May 24, 2024

Hello @ioolkos, I was able to compile Vernemq 1.13.0 with RocksDB support by picking the diff from new-feature-rocksdb-messagestore.

However, when I tried to define the directory of msg_store in vernemq.conf, it didn't take effect. It still pointed to ./data/msgstore. But I can confirm the value has been set to /var/lib/vernemq/data/msgstore with the following command. Also other configs did take effect (e.g. vmq_swc.db_backend, vmq_swc.directory etc.)

Do you have any idea why? Thanks!

# bin/vernemq config describe vmq_generic_msg_store.directory
Documentation for vmq_generic_msg_store.directory

   Valid Values:
     - the path to a directory
   Default Value : ./data/msgstore
   Set Value     : /var/lib/vernemq/data/msgstore
   Internal key  : vmq_generic_msg_store.msg_store_opts.store_dir

from vernemq.

ioolkos avatar ioolkos commented on May 24, 2024

@stepcheunghk Thanks, that setting seems to need some fixing then.
If you need to set a different directory for now, you can change it in the vmq_generic_msg_store.app.src file and recompile.


👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

stepcheunghk avatar stepcheunghk commented on May 24, 2024

@ioolkos Thanks again for your prompt response!

from vernemq.

ioolkos avatar ioolkos commented on May 24, 2024

@stepcheunghk since I want to merge RocksDB support eventually, I'm interested even if it'd be only anecdotical feedback.
Did you run Verne a bit on RocksDB? any observations so far?
I'll leave the issue closed here.


👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

ioolkos avatar ioolkos commented on May 24, 2024

@stepcheunghk No problem! It is your time and interest and very appreciated here.


👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

stepcheunghk avatar stepcheunghk commented on May 24, 2024

Hi @ioolkos, just a quick update, for the directory issue mentioned above, my current workaround is to use the old advanced.config. (https://github.com/ioolkos/vernemq/blob/rocksdb-messagestore/apps/vmq_generic_msg_store/priv/rocksdb_example_advanced.config)

from vernemq.

ioolkos avatar ioolkos commented on May 24, 2024

@stepcheunghk Thanks for the feedback! Of course, yes, the advanced.config file is an option for the directory setting. And we need to have an advanced config for RocksDB anyway.


👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

from vernemq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.