Comments (11)
This is exactly how I was doing it ;-)
from jssip.
+1 to this. However, this doesn't qualify for 0.2.X. It doesn't change the API, but it adds new elements to the public API, so we need to bump the version to 0.3.0.
Btw, can we come up with a namespace for this? JsSIP.getUserMedia applies only to WebRTC stuff, we can do more than WebRTC, potentially.
from jssip.
@saghul what would that namespace stand for?
from jssip.
I guess, for new features/API changes, the best thing is doing this on a self branch. Continue with the 0.2.x development until the 0.3.0 release, when the branch would be merged in master before releasing.
Same with other features tagged for future releases.
This feature would provide interoperability with browsers that implement (http://dev.w3.org/2011/webrtc/editor/webrtc.html) other than Chrome. While it is not a big change in the code, I believe it is worth to be released as a 0.3.0 feature.
from jssip.
@jmillan YES.
from jssip.
A few notes in firefox support I found:
- peerConnection.onicecandidate isn't called (https://bugzilla.mozilla.org/show_bug.cgi?id=827932), workaround is to call onSuccess inside createOffer/createAnswer, also comment out peerConnection.ononopen
- WebRTC setLocalDescription fails when offer has only G.711 codec (https://bugzilla.mozilla.org/show_bug.cgi?id=810220), workaround is to save sessionDescription into a variable
- interop w/ asterisk INVITE' faills because DTLS uses sha-256 and asterisk only supports sha-1, see http://lists.digium.com/pipermail/asterisk-dev/2013-January/058217.html
from jssip.
I propose a new file src/WebRTC.js
which includes the following functions:
JsSIP.WebRTC.getUserMedia()
which calls towebkitGetUserMedia()
ormozGetUserMedia()
.JsSIP.WebRTC.RTCPeerConnection()
which calls towebkitRTCPeerConnection()
ormozRTCPeerConnection()
.JsSIP.WebRTC.URL()
which calls towebkitURL()
ormozURL()
.
And then use those functions in the whole JsSIP code.
from jssip.
Let's check the JS WebRTC adapter code in the WebRTC demo app: https://apprtc.appspot.com/js/adapter.js
from jssip.
First approach in new "multi-browser" branch at commit 475cb16.
from jssip.
@ibc,
This issue can be closed IMHO.
from jssip.
Done in d26448e
from jssip.
Related Issues (20)
- JsSIP Logger Override Functionality Not Working As Expected in v3.7.7 HOT 1
- UnMute Call HOT 2
- How not to get microphone permission HOT 1
- For SIP server Account Register Working? HOT 2
- Abnormal session cancellation method under race condition
- Type definition errors in 3.10.0 HOT 1
- Error when getting video track status on Firefox
- Play audio or tone to remote user. HOT 2
- The new JsSIP.UA(configuration).call method does not return the status after execution
- import JsSIP from "jssip"; 打印JsSIP undefined HOT 2
- Error 'setLocalDescription' on Chrome HOT 1
- BYE: Request-URI does not point to us HOT 34
- Incorrect SDP a=sendrecv in firefox HOT 7
- I want to send and Receive message using JSSIP
- Sending a silent stream on latest Chrome HOT 1
- Error when trying to change the microphone during a call HOT 1
- Add custom header JsSIP - Asterisk HOT 1
- JsSIP processing re-INVITE HOT 1
- SDP is cut off between recieving 200 OK and the sdp event being emitted HOT 2
- On iOS, navigator.mediaDevices is `undefined` unless page is served in a secure context, but Errors are swallowed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jssip.