GithubHelp home page GithubHelp logo

Issues in Node tests about mediasoup HOT 3 CLOSED

ibc avatar ibc commented on May 31, 2024
Issues in Node tests

from mediasoup.

Comments (3)

ibc avatar ibc commented on May 31, 2024 1

NOTE: In tests above I'm doing this change to avoid more open handlers when a test file completes

I strongly dislike timeouts like that. They are not reliable and will definitely fail at some point.

Yes. It was the only one in the code.

from mediasoup.

ibc avatar ibc commented on May 31, 2024

NOTE: In tests above I'm doing this change to avoid more open handlers when a test file completes:

diff --git a/node/src/Channel.ts b/node/src/Channel.ts
index 7e1c71961..abb2f0468 100644
--- a/node/src/Channel.ts
+++ b/node/src/Channel.ts
@@ -227,16 +227,6 @@ export class Channel extends EnhancedEventEmitter {
 		this.#producerSocket.removeAllListeners('end');
 		this.#producerSocket.removeAllListeners('error');
 		this.#producerSocket.on('error', () => {});
-
-		// Destroy the socket after a while to allow pending incoming messages.
-		setTimeout(() => {
-			try {
-				this.#producerSocket.destroy();
-			} catch (error) {}
-			try {
-				this.#consumerSocket.destroy();
-			} catch (error) {}
-		}, 200);
 	}

from mediasoup.

nazar-pc avatar nazar-pc commented on May 31, 2024

NOTE: In tests above I'm doing this change to avoid more open handlers when a test file completes

I strongly dislike timeouts like that. They are not reliable and will definitely fail at some point.

from mediasoup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.