GithubHelp home page GithubHelp logo

Should depend on python2 about mediasoup HOT 11 CLOSED

versatica avatar versatica commented on May 15, 2024
Should depend on python2

from mediasoup.

Comments (11)

saghul avatar saghul commented on May 15, 2024 1

That's a problem, yeah. Not all platforms work with that shebang. I'd leave it as "python" and perform a runtime check:

if sys.version_info[0] != 2:
    raise RuntimeError('Python 2 is required')

from mediasoup.

saghul avatar saghul commented on May 15, 2024

Yes. GYP is Python 2 only.

from mediasoup.

notedit avatar notedit commented on May 15, 2024

there is no python2 on mac , i change that to python makes it work.

from mediasoup.

ibc avatar ibc commented on May 15, 2024

My /usr/bin/python in OSX has version "2.7.10". However there is no /usr/bin/python2 but /usr/bin/python2.7, so I cannot rely on env python2.

Also, when installing via brew install python it installs "2.7.11" and places both python and python2 in /usr/local/bin/, both are links that point to links that finally point to /usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/bin/python2.7.

In Debian 8.3 it happens the very same.

So I would replace #!/usr/bin/env python2 with #!/usr/bin/env python in configure.py, but that would fail if env python points to Python3, right @saghul?

Please, note that such a script is directly invoked from a make command when executing the main Makefile.

from mediasoup.

ibc avatar ibc commented on May 15, 2024

It seems that this could also work, but requires an extra step that I don't like:

$ npm config set python /usr/bin/python2.7  // or whatever

from mediasoup.

ibc avatar ibc commented on May 15, 2024

@saghul, will you send a PR soon regarding gyp.js?

from mediasoup.

saghul avatar saghul commented on May 15, 2024

So I would replace #!/usr/bin/env python2 with #!/usr/bin/env python in configure.py, but that would fail if env python points to Python3, right @saghul?

Correct. One such system is Arch Linux or the latest Ubuntu.

from mediasoup.

saghul avatar saghul commented on May 15, 2024

will you send a PR soon regarding gyp.js?

Not anytime soon, I'm afraid :-S Sorry!

from mediasoup.

ibc avatar ibc commented on May 15, 2024

I want my money back!

from mediasoup.

notedit avatar notedit commented on May 15, 2024

i think this will work well


That's a problem, yeah. Not all platforms work with that shebang. I'd leave it as "python" and perform a runtime check:

if sys.version_info[0] != 2:
    raise RuntimeError('Python 2 is required')

from mediasoup.

ibc avatar ibc commented on May 15, 2024

One problem I see is:

The host has both python2 and python3, and env python points to python2. Then #!/usr/bin/env python would just fail.

In the other side, in a fresh OSX (no brew installed) python2 is installed by default, it provides /usr/bin/python but it does not provide /usr/bin/python2...

from mediasoup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.