Comments (11)
That's a problem, yeah. Not all platforms work with that shebang. I'd leave it as "python" and perform a runtime check:
if sys.version_info[0] != 2:
raise RuntimeError('Python 2 is required')
from mediasoup.
Yes. GYP is Python 2 only.
from mediasoup.
there is no python2 on mac , i change that to python makes it work.
from mediasoup.
My /usr/bin/python
in OSX has version "2.7.10". However there is no /usr/bin/python2
but /usr/bin/python2.7
, so I cannot rely on env python2
.
Also, when installing via brew install python
it installs "2.7.11" and places both python
and python2
in /usr/local/bin/
, both are links that point to links that finally point to /usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/bin/python2.7
.
In Debian 8.3 it happens the very same.
So I would replace #!/usr/bin/env python2
with #!/usr/bin/env python
in configure.py
, but that would fail if env python
points to Python3, right @saghul?
Please, note that such a script is directly invoked from a make
command when executing the main Makefile.
from mediasoup.
It seems that this could also work, but requires an extra step that I don't like:
$ npm config set python /usr/bin/python2.7 // or whatever
from mediasoup.
@saghul, will you send a PR soon regarding gyp.js?
from mediasoup.
So I would replace #!/usr/bin/env python2 with #!/usr/bin/env python in configure.py, but that would fail if env python points to Python3, right @saghul?
Correct. One such system is Arch Linux or the latest Ubuntu.
from mediasoup.
will you send a PR soon regarding gyp.js?
Not anytime soon, I'm afraid :-S Sorry!
from mediasoup.
I want my money back!
from mediasoup.
i think this will work well
That's a problem, yeah. Not all platforms work with that shebang. I'd leave it as "python" and perform a runtime check:
if sys.version_info[0] != 2:
raise RuntimeError('Python 2 is required')
from mediasoup.
One problem I see is:
The host has both python2 and python3, and env python
points to python2. Then #!/usr/bin/env python
would just fail.
In the other side, in a fresh OSX (no brew installed) python2 is installed by default, it provides /usr/bin/python
but it does not provide /usr/bin/python2
...
from mediasoup.
Related Issues (20)
- announced_ip can also be a hostname (not possible in Rust)
- Rename "announced ip" to "announced address"
- [Rust] `Box<dyn Error>` error types make mediasoup error handling annoying HOT 1
- Wrong handle of response in Channel.ts? HOT 1
- Fail to compile mediasoup fuzzer due to liburing HOT 21
- Fuzzer fails immediately due to abseil: AddressSanitizer: SEGV HOT 12
- (ABORT) RTC::RTCP::FeedbackRtpTransport::AddPacket() | failed assertion `baseSet': base not set HOT 4
- OpenSSL send buffer growing without bounds in DtlsTransport (worker memory leak) HOT 22
- Implement FLEX FEC - RFC 8627
- Memory leak HOT 6
- Multi-thread bug when using usrsctp in N Worker threads in Rust HOT 1
- opus dtx incorrectly judged HOT 7
- Possible missing break in H264_SVC::ParseSingleNalu()
- Must join all XxxConsumer classes into a single one
- set MS_LOG_DEV_LEVEL 3, lead to build errors HOT 1
- #define MS_LOG_DEV_LEVEL 3, build error HOT 1
- SeqManager<T>::SeqLowerThan() crashes when used as compare function in abseil set or map (only in debug mode) HOT 24
- Use uint64_t for containers with RTP seq number as key
- arm64 prebuilt binaries are replacing x64 ones HOT 4
- test-PipeTransport.ts randomly fails HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mediasoup.