GithubHelp home page GithubHelp logo

Comments (8)

Ralf1108 avatar Ralf1108 commented on May 21, 2024

never heard of "development dependency" before.. so I will have to investigate this first

from methodboundaryaspect.fody.

Ralf1108 avatar Ralf1108 commented on May 21, 2024

do you mind make the required change and provide a pull request? :-)

from methodboundaryaspect.fody.

damageboy avatar damageboy commented on May 21, 2024

I think he means that the MethodBoundayAspect.csproj should contain the package references as explained in the basicfodyaddin README.md:

https://github.com/Fody/BasicFodyAddin/blob/9e28d1dd2b89bc77588f510dfe7174b5623b13ee/BasicFodyAddin/BasicFodyAddin.csproj#L11:

  <ItemGroup>
    <PackageReference Include="Fody" Version="3.0.3" PrivateAssets="None" />
    <PackageReference Include="FodyPackaging" Version="3.0.3" PrivateAssets="All" />
  </ItemGroup>

The PrivateAssets=... attributes (also) control how the resulting nupkg will look

from methodboundaryaspect.fody.

Ralf1108 avatar Ralf1108 commented on May 21, 2024

we try to separate the weaver stuff and the OnMethodBoundary base class into separate assemblies. Then we could remove the dependency to fody for the latter one.

from methodboundaryaspect.fody.

PulsarFX avatar PulsarFX commented on May 21, 2024

Um, there is no dependency on Fody or Cecil from MethodBoundaryAspect.dll - that is fine.

I think it is enough to modify the nuget package spec like shown in comment by damageboy.
There is also a spec page on this at https://blog.nuget.org/20170316/NuGet-now-fully-integrated-into-MSBuild.html

from methodboundaryaspect.fody.

marcells avatar marcells commented on May 21, 2024

We also want to use a lower Target Framework (e.g. 4.5.2) for our base class. That is only possible by separating the base class and runtime attributes from the weaving code. The weaving code is dependent on FodyCecil, why it has to be at lease 4.6.

from methodboundaryaspect.fody.

PulsarFX avatar PulsarFX commented on May 21, 2024

ah ok, fair enough ;)
I had to go back to v0.35 to get .net4.5.2 support on a project where I was not able to set .net 4.6.2 as the base because of contract stuff

from methodboundaryaspect.fody.

marcells avatar marcells commented on May 21, 2024

I made released a new version (1.0.41) right now. It should be possible to use the aspect under .NET 4.5.1. I did also mark the packages a developmentDependency.

Could you check, if it is working for you and reopen the issue, if not?

from methodboundaryaspect.fody.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.