Client API design and code about nebula-go

[Aiee]

Hi sirkon,

Thank you for your time and your insightful suggestions for Nebula go client, and I am sorry for any inconvenience you had when using go client. You are right, back in the days when the dev team was lack of experience coding in golang, we didn't polish it well.

As the release date of Nebula 2.0 is approaching, we have redesigned the client, with the concerns we hear from the users. I will give you a brief introduction of the changes we made regarding the suggestions you gave:

• Code style and layout issues
  • Everything is formatted now!
  • Libraries are reorganized now so that the only module the user needs to import is nebula "github.com/vesoft-inc/nebula-go", which simplifies the development for users.
• Code issues

  • Logging:

    • Choosing a logger to use as the default client log may cause duplicated logs when users use a different logger. Since we don't know what loggers our users are using, we decided to create a logger interface that allows the user to implement the method in the interface with their preference of logger choice.

  • Error processing:

    • We have refactored the error processing. A typical error handling case will be like:

    // Create session
    session, err := pool.GetSession(username, password)
    if err != nil {
      log.Fatal(fmt.Sprintf("Fail to create a new session from connection pool, username: %s, password: %s, %s",
    	  username, password, err.Error()))
    }
    

Again, I want to thank you for using Nebula and being a part of the community. Your feedback is important to us. Please let us know if there is anything else you think is off or we can improve on.

Have a nice day!