Comments (6)
Did some debugging, here's what happening:
File "C:\src\optimize-images\optimize_images\img_optimize_jpg.py", line 80, in optimize_jpg
piexif.transplant(os.path.expanduser(task.src_path), tmp_buffer)
File "C:\src\optimize-images\venv\lib\site-packages\piexif_transplant.py", line 26, in transplant
if image[0:2] == b"\xff\xd8":
TypeError: '_io.BytesIO' object is not subscriptable
It seems that transplant
wants real file as 2nd parameter, but gets BytesIO instead. At same time it seems that BytesIO can be used as a 3rd parameter.
from optimize-images.
Hi! Thanks for reporting this issue. It seems to be happening on piexif's side, but it needs to be investigated. Does it happen always, regardless of the image file being processed?
Can you please provide the output of optimize-images --version
(please anonymise the file paths if necessary)?
from optimize-images.
Looks like here:
piexif.transplant(os.path.expanduser(task.src_path), tmp_buffer)
you're giving tmp_buffer
that is BytesIO
. But transplant
wants path to actual file.
Always the same.
I'm using latest revision from this repo.
from optimize-images.
I understand. Thanks for the details. It should not be very complicated to fix, but I can't promise a date.
I will try to fix in a few days it if no one submits a pull request first.
from optimize-images.
You actually don't need piexif, Pillow can handle this:
Load all EXIF data:
exif = img.info['exif']
Save it:
img.save('P4072956_thumb.jpg', exif=exif)
from optimize-images.
pip install optimize-images==1.4
does not suffer from this problem
from optimize-images.
Related Issues (20)
- skip optimization on error, don't exit process HOT 1
- log what file is raising error HOT 6
- Use imghdr.what() to detect image type from file signature in do_optimization()
- Skip non-image file types HOT 4
- AttributeError: 'NoneType' object has no attribute 'orig_size' HOT 3
- Command line icons not properly shown in Windows HOT 5
- PIL.UnidentifiedImageError: cannot identify image file HOT 6
- Keep Image resolution (DPI) HOT 3
- Allow export to format ".webp" HOT 2
- [Feature Request] Option to skip files raising exceptions. HOT 2
- Read-only file system /~temp~image.png HOT 7
- Convert png to jpg regardless of size HOT 2
- [Feature Request] Docker support HOT 10
- Brunsli support? HOT 1
- Claims Pillow isn't installed while it is? HOT 5
- Skips png's HOT 2
- Ability to Suppress Output HOT 2
- UnboundLocalError: local variable 'has_exif' referenced before assignment HOT 4
- Error with Pillow 8.2.0 and python 3.10 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from optimize-images.