Comments (4)
Hi @MisguidedEmails ,
Thanks for the fix!
Note: May be worth having some sort of schema validation (or dry/actual run against a kind cluster or something) to catch oversights like this.
Indeed, there is a chart installation test on several k8s versions, to ensure each chart can be installed successfully with default values, but this was missing because it's triggered by specific value(
from helm-charts.
Indeed, there is a chart installation test on several k8s versions, to ensure each chart can be installed successfully with default values, but this was missing because it's triggered by specific value
Hrm, but it's rendered by default? No specific values are required to present this problem (since it's an if/else). It seems like the pipeline might not be catching those type of errors. If I do a helm template .
on the pre-fix code, it outputs the invalid tcpSocket
with no additional values presented.
from helm-charts.
Interesting, a helm install doesn't appear to care? But it is invalid. helm install vm-test .
installs fine, ignoring that invalid part, but helm install vm-test --dry-run
shows that the scheme:
is there.
from helm-charts.
@Haleygo - I've raised #852 as a fix for the problem. Since helm doesn't appear to error on invalid manifests, and neither do the chart testing or helm lint
tools. Using kubectl
appears to be the only option.
I'll close this issue, since the original problem is fixed.
from helm-charts.
Related Issues (20)
- [victoria-metrics-k8s-stack] Kind VMAgent "null" value in remoteWrite cause failed to helm install HOT 3
- Publish helm charts also as an OCI package (e.g. on GHCR registry)
- victoria-metrics-k8s-stack - VMServiceScripe for the operator is created twice HOT 2
- vmsingle is deployed eventhough is set to false HOT 3
- Can't install victoria-metrics-k8s-stack using Terraform helm provider HOT 2
- Issue with default k8s VMRules. HOT 9
- Expose streaming aggregation config in vmagent chart HOT 4
- Labels should be truncated HOT 4
- Helm Charts: missing Ingress Definition for TLS
- Cannot support existingClaim and different pvc for different vmstorage pods at the same time HOT 12
- Add a `vmstorage.vmbackup.enabled` value to the `victoria-metrics-cluster` chart HOT 1
- Added values file option for -remoteWrite.relabelConfig & -remoteWrite.urlRelabelConfig HOT 5
- Allow setting `metricRelabelings` on ServiceMonitors
- Support options for vmagent to scrape targets via a proxy HOT 2
- Duplicated VictoriaMetrics datasource HOT 1
- [k8s-stack/kube-etcd] Cannot specify mTLS auth configuration HOT 2
- Custom container port name is not supported. HOT 3
- Outdated CRD on victoria-metrics-k8s-stack chart HOT 2
- config-reloader liveness checks failing in victoria-metrics-k8s-stack 0.21.0 HOT 3
- Typo in Role template for Victoria-metrics-operator HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-charts.