GithubHelp home page GithubHelp logo

Comments (4)

Haleygo avatar Haleygo commented on September 20, 2024

Hi @MisguidedEmails ,
Thanks for the fix!

Note: May be worth having some sort of schema validation (or dry/actual run against a kind cluster or something) to catch oversights like this.

Indeed, there is a chart installation test on several k8s versions, to ensure each chart can be installed successfully with default values, but this was missing because it's triggered by specific value(

from helm-charts.

MisguidedEmails avatar MisguidedEmails commented on September 20, 2024

Indeed, there is a chart installation test on several k8s versions, to ensure each chart can be installed successfully with default values, but this was missing because it's triggered by specific value

Hrm, but it's rendered by default? No specific values are required to present this problem (since it's an if/else). It seems like the pipeline might not be catching those type of errors. If I do a helm template . on the pre-fix code, it outputs the invalid tcpSocket with no additional values presented.

from helm-charts.

MisguidedEmails avatar MisguidedEmails commented on September 20, 2024

Interesting, a helm install doesn't appear to care? But it is invalid. helm install vm-test . installs fine, ignoring that invalid part, but helm install vm-test --dry-run shows that the scheme: is there.

from helm-charts.

MisguidedEmails avatar MisguidedEmails commented on September 20, 2024

@Haleygo - I've raised #852 as a fix for the problem. Since helm doesn't appear to error on invalid manifests, and neither do the chart testing or helm lint tools. Using kubectl appears to be the only option.

I'll close this issue, since the original problem is fixed.

from helm-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.