Comments (4)
zekker6
commented on July 2, 2024
2
From the security POV this seems to be a very good suggestion, thanks @wasim-nihal!
It would be important to make sure that all credentials comparison functions will be converted to constant time comparison.
from victoriametrics.
hagen1778
commented on July 2, 2024
1
I like this proposal as well!
from victoriametrics.
wasim-nihal
commented on July 2, 2024
1
Thanks, @zekker6 , @hagen1778 for accepting the proposal!!
It would be important to make sure that all credentials comparison functions will be converted to constant time comparison.
As of now, I have taken note of only authkey and basic auth credential comparison. I will explore the codebase a bit more and see where such similar comparisons are made and open the PRs (maybe in stages). Any heads-up would be helpful 🚀
from victoriametrics.
Haleygo
commented on July 2, 2024
@zekker6 @f41gh7 @hagen1778 Could you share some thoughts here?
from victoriametrics.
Related Issues (20)
- How to add label ? HOT 4
- Alerting rule `RecordingRulesNoData`'s annotations use missing `recording` label HOT 1
- In the victoria-logs ui make the relative range control relative to the time when the query is run.
- victorialogs: optimize sort performance
- Vm auth: if the request does not fully cache the body to buf due to server connection disconnection, it will not be retried. HOT 1
- No data for several endpoints, including Active Targets HOT 2
- vmauth: a way to stop proxying Host header
- vmselect gets timeout when request /api/v1/label/.../values HOT 8
- The metric `process_resident_memory_bytes` was not calculated correctly HOT 1
- Global WITH templates in vmselect / vmsingle
- vmauth cannot start with empty configuration. HOT 1
- vmauth: default httpserver incorrectly exposed
- VMAlert oauth2 error HOT 2
- vmagent using k8s endpoint role for pod role jobs HOT 7
- kube-scheduler and kube-controller-manager scrape tls issue on victoria-metrics-k8s-stack HOT 3
- Add type parameter to prometheus metrics in vmagent HOT 2
- GetRowsDiff func takes a lot of time when vmagent pushes kube-state-metrics data HOT 3
- Using Query from the beginning of the day HOT 1
- Allow VMAlert to replay alerts till the current time HOT 2
- Different authorization for different targets, via relabel
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from victoriametrics.