Comments (4)
@hagen1778, do you have a sense whether this is actionable? It's currently causing embarrassingly incomplete/incorrect charts in our customer-facing web application, so I'd like to understand whether a fix might be forthcoming or if I need to hunt for workarounds. 😅
I've noticed that keep_last_value()
and keep_next_value()
also don't appear to utilize samples outside of the query window (if I'm reading the code correctly). I don't use those functions in my application so that's not an immediate problem for me, but I would have expected them to look outside the query window in the same way I expected interpolate()
to.
from victoriametrics.
Hello @mactyr! In the current implementation, all transform functions have no knowledge about datapoints outside the interval. I don't know yet if this is actionable - I need feedback from @valyala who originally added this function.
from victoriametrics.
Hey @mactyr! It is unlikely we're going to change transform functions to capture data before and/or after the requested interval, in the same fashion as rollup functions do. This could be a severe change.
But I think it could be possible to use data samples on the requested interval in order to extrapolate missing data points. It should work perfectly with monotonically increasing counter from your example, but will be partially correct for other cases. wdyt?
from victoriametrics.
Thanks for offering that change, @hagen1778, but extrapolating from the samples within the interval definitely isn't safe with our real data, where the rate of change varies quite a bit over time.
My first impulse is to ask if there could be a version of interpolate that is a rollup (like interpolate_rollup()
?) but I see how it's a little unclear what the lookbehind window would mean for that function, which is probably why @valyala chose to implement interpolate()
as a transform in the first place.
So my next question is whether you all could take another look at #3079 and see whether that might be actionable? What I'm really trying to do here is just get the increase()
without assuming that the counter had a value of 0 if there's no sample found prior to the query window. Because I couldn't get the result I needed with the existing family of "increase" functions, I settled on the workaround of doing ascent_over_time(interpolate(metric{}))
instead, which usually works well enough but has the problem described in this issue. If I had an increase-like function that worked as desired, I think I could get away from relying on interpolate()
so much.
from victoriametrics.
Related Issues (20)
- The metric `process_resident_memory_bytes` was not calculated correctly HOT 1
- Global WITH templates in vmselect / vmsingle
- vmauth cannot start with empty configuration. HOT 1
- vmauth: default httpserver incorrectly exposed
- VMAlert oauth2 error HOT 1
- vmagent using k8s endpoint role for pod role jobs HOT 6
- kube-scheduler and kube-controller-manager scrape tls issue on victoria-metrics-k8s-stack HOT 3
- Add type parameter to prometheus metrics in vmagent HOT 2
- GetRowsDiff func takes a lot of time when vmagent pushes kube-state-metrics data HOT 3
- Using Query from the beginning of the day HOT 1
- Allow VMAlert to replay alerts till the current time HOT 2
- Different authorization for different targets, via relabel
- IndexDB data consuming more space after pod restarts HOT 3
- Indexdb add scroll mode when vmstorage -retentionPeriod parameter set very long time
- vmalert-tool: process won't exit when no rule is defined under group HOT 1
- Duplicate metrics in a scrape break Prometheus scraping HOT 1
- Victorialogs can't parse syslog timestamps HOT 4
- victorialogs vmui: unresponsive after query execution HOT 1
- Random inconsistent results in query operations from the same instance and exporter HOT 3
- vmalert: replay exit with status 0 when generated samples are not successfully pushed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from victoriametrics.