_throttle does not flush

jannschu

Hi, I debugged space rooms not loading in my case and I found an issue with `_throttle` in this case for the async stream: https://github.com/viktorstrate/mactrix/blob/5b846c02c41175917a60ee60e9942a3d3a0338cc/Mactrix/Models/LiveSpaceRoomList.swift#L95-L99 It seems `_throttle` emits the first event right away and buffers elements arriving within the next 500ms. The problem seems to be that those are only flushed if now another element arrives or the base sequence finishes. In my case this reliably caused the loader to get stuck. To confirm I temporarily removed the throttle there and also in `LiveSpaceService.swift`. I am not sure about the proper fix. I think the listener already receives batched updates and this probably happens infrequently, so maybe no throttle is needed? edit: Maybe also worth looking into other places where _throttle is used? edit2: In particular `Mactrix/Models/LiveTimeline.swift`, here I also saw partial timelines.

viktorstrate

Good find! A PR fixing this would be highly appreciated. There might also be other instances of `_throttle` in the codebase and they're probably all wrong.

viktorstrate

I have removed the throttle code temporarialy to ensure that all updates are included. When this upstream issue is solved https://github.com/apple/swift-async-algorithms/issues/266 we can implement a working throttle again.