Option to support tnoremap about vim-vimlparser

[RianFuro]

I implemented neovim support a while back actually in #19.
Since the neovim command set actually removes quite a few commands still existing in vim-space, enabling neovim support is a toggle rather than being built in (because it would conflict with the existing vim command set).
You can enable neovim support by passing true as the 2nd parameter to vimlparser#test(input, ...); or use the --neovim command line parameter for the js/python command line tools.

[sassanh]

Thanks, yeah it works alright with --neovim

[sassanh]

@RianFuro I were able to test it by adding --neovim in line 11 of node_modules/vimlint/lib/vimlint.js (adding it to the arguments it calls the .sh file with) but vimlint --neovim <somepath> outputs this:

error: unknown option `--neovim'

Any idea about this?

[sassanh]

I guess the npm package is not related to this repo. Right?

[RianFuro]

@sassanh well, I guess both the vimlint and the node-vimlint projects are using this codebase here as a dependency to destruct vim code into an AST. Since neovim support should be already provided by my pr (though it could certainly do better, like proposed in #22), it's on the respective projects using the vimlparser to utilize this.

I suppose we could talk about the activation mechanism for neovim support if it's not sufficient... but since @ynkdir seems awfully inactive the last months, I doubt anything will come from it.

[RianFuro]

Also, to answer your first question: Since you only outlined your attempt I can only guess, but since you want to use it via the executable, you'd also have to adapt their argument parser to make vimlint recognize the --neovim option and then correctly pass it over to the call to the vimlparser.

[sassanh]

@RianFuro thanks for info. vimlint (the npm package) uses vimlint.sh from vim-vimlint which uses vim-vimlparser internally. So I ended up changing line 1943 of autoload/vimlint.vim to

  let p = s:vlp.VimLParser.new(1)

I hope I can manage my time so that I can create a PR for it (not by above method ofc, as it's just a dirty hack.) We can consider using has('nvim') instead of passing an argument too.

[RianFuro]

For the native implementation that would do. The transpiled js and python scripts don't have that option though :/

[haya14busa]

I wonder can we add less strict mode which just focus on parsing Vim script and skip checking correctness of the script.

This problem is not only related with neovim-only commands, but also with newly added commands to Vim itself.

[nickspoons]

To add to what @haya14busa said, vim now also has tmap, tnoremap etc. and these are currently flagged as errors

[tyru]

maybe #67 fixed this?