If a textbox has not get been selected normal mode command gi results in a TypeError about vimperator-labs

[maxauthority]

Works here with Firefox32. Can you give a concrete URL where that happens?

[arsenerei]

I just checked again. Firefox works as expected. It's in Aurora that I'm having the issue.

http://www.reddit.com/

[Mine02C4]

It seems that this issue is caused by this bug. https://bugzilla.mozilla.org/show_bug.cgi?id=533162
But, this was created 5 years ago, this has been left...

[Mine02C4]

Related code

vimperator-labs/common/content/buffer.js

Line 1640 in 22faadf

let elements = [m for (m in util.evaluateXPath(xpath))

vimperator-labs/common/content/util.js

Line 411 in 22faadf

: function () { for (let i = 0; i < this.snapshotLength; i++) yield this.snapshotItem(i); };

[caisui]

There is reproduced in Firefox 33.(Not Firefox 32)

I wrote patch.
caisui@f064f04

This patch is unwrapped XPathResult object.
If there are other ways, I think it is better than this patch.

[Mine02C4]

@caisui In my environment, the patch works well.

[maxauthority]

Then please push it, thanks.

On Mon, Oct 6, 2014 at 9:05 PM, mine02c4 [email protected] wrote:

@caisui https://github.com/caisui In my environment, the patch works
well.

—
Reply to this email directly or view it on GitHub
#33 (comment)
.

[protrolium]

so what exactly is the fix to this issue? Firefox 33 for me also throws the error

TypeError: m.getClientRects is not a function

when calling 'gi' in normal mode.

[krzkrzkrz]

This issue is still happening. Has the fix been released?

[caisui]

Rewrite path.
please test it.

caisui@5c0f44e

[derenio]

@caisui I can confirm that the rewrite has fixed the regression #76

[fohrums]

Problem is persistent on my end.

FF 33, Vimperator 3.8.2

this happens when I want to gi to an insert field. Possible to bypass by clicking around the page and re-doing a gi.

[shouya]

@fohrums Have you tried to build the latest Vimperator from the source?

I have this problem resolved after it merged #82.

[apnof]

@caisui

Rewrite path.
please test it.
caisui/vimperator-labs@5c0f44e

seems to work for me (ffox 33).
Thanks.

[fohrums]

@shouya No I have not, i'm afraid it's because I don't know how.

[shouya]

It's fairly easy @fohrums, just:

$ git clone https://github.com/vimperator/vimperator-labs.git
$ cd vimperator-labs
$ make

And you will get a vimperator-3.8.X.xpi, then just install it in your firefox ;-)

[fohrums]

It's funny, because I never find myself "NOT" needing sudo. so are these
directions always mentioned for the general purpose?

btw, I found out that there was a "make xpi" command and found it in a
subfolder

Also I think I got it to work but it still says v3.8.2.

On Tue, Nov 11, 2014 at 11:48 AM, Shou Ya [email protected] wrote:

It's fairly easy @fohrums https://github.com/fohrums, just:

$ git clone https://github.com/vimperator/vimperator-labs.git
$ cd vimperator-labs
$ make

And you will get a vimperator-3.8.X.xpi, just install it in your firefox
;-)

—
Reply to this email directly or view it on GitHub
#33 (comment)
.

[shouya]

@fohrums that's cool. but I don't know what do you exactly mean by 'general purpose'.

[fohrums]

Well, I was hoping to get an explanation between "make" and "make xpi"
general purposes meaning when explaining commands we tend not to put
"sudo..." because it's seen as useless language when you want to give
simple commands to explain things.

On Wed, Nov 12, 2014 at 1:09 PM, Shou Ya [email protected] wrote:

@fohrums https://github.com/fohrums that's cool. but I don't know what
do you exactly mean by 'general purpose'.

—
Reply to this email directly or view it on GitHub
#33 (comment)
.

[shouya]

GNU Make by default build the first target if no argument specified. You may want to check http://mrbook.org/tutorials/make/ for understanding how they works.

You won't need a sudo unless you need to grant the privilege as root, for example, install files in system-wise directory, etc.

Seems somewhat off-topic to discuss these stuff here. Nonetheless, if you want to know more, sending me an email is welcomed :)

[caisui]

Rewrite patch again...
Please test it.

caisui@1ae4fd2

see #81

[maxauthority]

caisui: Once the patch is deemed good enough, can you please send a pull
request (or push it directly)? Such inline-patches are easy to be
overlooked by me :(

On Sat, Nov 15, 2014 at 9:56 AM, caisui [email protected] wrote:

Rewrite patch again...
Please test it.

caisui/vimperator-labs@1ae4fd2
caisui@1ae4fd2

see #81 #81

—
Reply to this email directly or view it on GitHub
#33 (comment)
.

[oniatsu]

The almost same problem occured in Firefox 35.0 with Vimperator 3.8.3.
But the error message is different. The following message is displayed:

TypeError: 'snapshotLength' getter called on an object that does not implement interface XPathResult.

[oniatsu]

I tried again to use 'gi' with Vimperator 3.8.3-a3, then the probrem did not occur.

[protrolium]

if i may ask, where did you get alpha 3 and how did you install it? i am having the problem with 'gi' you described with the different error message

[gkatsev]

Alpha 3 is available in github releases: https://github.com/vimperator/vimperator-labs/releases/tag/3.8.3-a3

[derenio]

@protrolium as @gkatsev has mentioned, the a3 version is a tag of this repository.
To build it and install do as follows:

cd **SOMEWHERE**
git clone https://github.com/vimperator/vimperator-labs/
cd vimperator-labs
git checkout 3.8.3-a3
make
# to install the created `xpi` file into your firefox type the below into its `command line`
:open file:///**SOMEWHERE**/vimperator-labs/downloads/vimperator-3.8.3.xpi

[gkatsev]

There's a pre-build XPI available in my link, also.

[protrolium]

thank you @gkatsev + @derenio ... I was also having problems with ' ]] ' and ' [[ '
alpha 3 seems to have fixed it for now.

[gkatsev]

Seems to be fixed in master/a3. I'm not seeing this behavior anymore either. Going to close this for now. Please let us know if the issue persists or returns.