Various problems with muttator about vimperator-labs

[maxauthority]

Yeah, thanks for the reports. We know Muttator was neglected quite a lot
recently, it just seems also the developers prefer using webmail. Any
patches fixing the issues would be welcome, though. Having a standalone
vim-like mail client is certainly still something many would like.

On Fri, Oct 3, 2014 at 2:39 AM, Jan Larres [email protected] wrote:

I recently decided to give muttator a try, and it definitely makes using
Thunderbird much nicer. However, there seem to be some issues with current
Thunderbird versions, at least with version 31.1.2 which I'm using.

• The J/K keys for jumping to the next/previous unread message only
  result in the message TypeError: thread.getChildAT is not a function.
• Trying to close a tab sometimes (but apparently not always) results
  in TypeError: recentlyClosedTabs method called on incompatible Object.
• The normal Vim keys like j/k/ctrl-d/n etc. don't seem to work in
  help tabs.
• I can't seem to get the external editor support to work at all for
  writing messages.
• I also got a TypeError the first few times I tried the :help
  command, but I don't seem to be able to reproduce that now.

—
Reply to this email directly or view it on GitHub
#47.

[majutsushi]

So after some fiddling (I don't really have any extension development experience) I at least got the first issue fixed. Since it's a one-line change I'm just going to put it here instead of creating a pull request.

In content/mail.js the line 379 has to be changed from

msg = thread.getChildAt(j);

to

msg = thread.getChild(thread.getChildKeyAt(j));

I don't really understand why this is necessary as the documentation seems to indicate that the method should still be there, but apparently it isn't.

[maxauthority]

Thanks for the investigation! Can you somehow find out since when do we
have the thread.getChild(thread.getChildKeyAt(j)); methods in Thunderbird?
I don't mind increasing the minVersion, but if we don't do it, it might
break Muttator for older Thunderbird users.

On Mon, Oct 6, 2014 at 4:06 AM, Jan Larres [email protected] wrote:

So after some fiddling (I don't really have any extension development
experience) I at least got the first issue fixed. Since it's a one-line
change I'm just going to put it here instead of creating a pull request.

In content/mail.js the line 379 has to be changed from

msg = thread.getChildAt(j);

to

msg = thread.getChild(thread.getChildKeyAt(j));

I don't really understand why this is necessary as the documentation
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIMsgThread
seems to indicate that the method should still be there, but apparently it
isn't.

—
Reply to this email directly or view it on GitHub
#47 (comment)
.

[majutsushi]

So just because I could I actually had a look at the Thunderbird source history and discovered that the getChildAt() method got removed in 2011 due to bug 617839, and apparently someone forgot to update the documentation. I couldn't figure out when the other two methods got introduced but they definitely have been there since at least 2008.

[maxauthority]

Thanks for the investigation. I pushed your change! Feel free to also send patches for the other remaining issues :)

[majutsushi]

The external editor support is actually working for me now, I must have missed something the first time I tried it. The other issues are rather minor and/or hard to reproduce, so feel free to close this issue for now. I'll open a new one/pull request in case I'm able to find/fix anything specific.