ColorDrawable support about roundedimageview

[vinc3m1]

If you don't mind testing, please update your dependencies to use the snapshot and let me know how it performs:

repositories {
    mavenCentral()
    maven {
        url "https://oss.sonatype.org/content/repositories/snapshots"
    }
}
dependencies {
    compile 'com.makeramen:roundedimageview:1.2.4-SNAPSHOT'
}

[hamidp]

Will try it out.

I actually ended up implementing a RoundedColorDrawable that works very well that I had planned to PR

[thevery]

doesn't work for me with custom drawable (it seems that wrong canvas size (1x1) is passed)

[vinc3m1]

what custom drawable are you passing in?

[thevery]

nothing very special, just public class AvatarDrawable extends Drawable with it's own onDraw implementation with some drawText's.

[vinc3m1]

Ah, I would do one of 2 things:

• Return a value > 1 in getInstrinsicHeight() and getIntrinsicWidth(). This method would fix the canvas size of 1 issue, but whatever size you return will be the size of the bitmap that gets drawn, and later stretched to fit (probably not what you want).
• Instead I recommend extending RoundedImageDrawable instead of Drawable and simply doing your text drawing after calling super.onDraw

[thevery]

first one is obviously not a solution, neither is the second one - I must call super(null); in constructor and this causes NPE.
NB: I override draw, not onDraw in Drawable (later one is for View).

[vinc3m1]

why must you call super(null)? you can just let RoundedDrawable handle the bitmap part of your avatar, so call super.draw(canvas) and just use super.setBitmap() (or res or drawable).

Otherwise if you're already doing all the custom drawing just do canvas.drawCircle(cx, cy, r, bitmapPaint) and you don't even need this library...

[thevery]

I don't have any bitmap part of avatar.
All custom drawing (and especially round cropping) is already done, but using some library will make my code much more simple.

[vinc3m1]

This library is a convenience for people who don't want to write custom views and specifically optimizes for the case of rounded bitmaps. It's not meant to augment custom views/drawables well since the behavior most custom views is, well... very custom. It's impossible to predict how all custom views will work and accommodate for all of them.

Like I said, if your view has extra behavior on top of being rounded, I suggest extending or forking this library to reuse the code, otherwise supporting arbitrary custom drawables and views is not the aim of this library.

[hamidp]

Snapshot build does round the corners for us on color drawables. Once it's officially released we'll switch to using it.

Thanks!

[vinc3m1]

Cool, there are still some bugs I can't seem to hunt down (see example app), but if it works for most cases I'll push up the new version now.

[thevery]

@vinc3m1 I fully agree on your points about limited features support and forking, the only problem is that you realize limitations only after the first run and spend useless efforts on adding library to your project.