GithubHelp home page GithubHelp logo

Comments (8)

vincaslt avatar vincaslt commented on May 28, 2024

Thanks for the report, it's a bug in the extension. It's a simple fix it seems.

from vscode-highlight-matching-tag.

vincaslt avatar vincaslt commented on May 28, 2024

3f17e95

This ought to fix it. I'm closing the issue now, reopen if it still persist with some other cases. You can update the extension in vscode with the change.

from vscode-highlight-matching-tag.

KamasamaK avatar KamasamaK commented on May 28, 2024

I am unable to reopen this issue, but the following line is giving the same error with nearly identical stack trace:
<cffile action="read" file="#directory#\#fileName#" variable="localFile">

The backslash seems to be what is causing the issue as it works fine when removed.

Stack trace:

at Lexer.next (C:\Users\<User>\.vscode\extensions\vincaslt.highlight-matching-tag-0.8.0\node_modules\moo\moo.js:397:13)
at Object.parseTags (C:\Users\<User>\.vscode\extensions\vincaslt.highlight-matching-tag-0.8.0\out\src\tagParser.js:79:36)
at vscode.window.onDidChangeTextEditorSelection (C:\Users\<User>\.vscode\extensions\vincaslt.highlight-matching-tag-0.8.0\out\src\extension.js:56:38)
at e.fire (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:99:496)
at e.$acceptEditorPropertiesChanged (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:589:930)
at t._doInvokeHandler (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:640:888)
at t._invokeHandler (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:640:554)
at t._receiveRequest (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:639:126)
at t._receiveOneMessage (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:638:59)
at c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:635:926
at c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:98:138
at e.fire (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:99:496)
at a (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:154:213)
at Socket.n._socketDataListener (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:154:432)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)
at readableAddChunk (_stream_readable.js:250:11)
at Socket.Readable.push (_stream_readable.js:208:10)
at Pipe.onread (net.js:594:20)

from vscode-highlight-matching-tag.

vincaslt avatar vincaslt commented on May 28, 2024

Fixed cases like the above in v0.8.3

from vscode-highlight-matching-tag.

KamasamaK avatar KamasamaK commented on May 28, 2024

I found another case that causes this error. It is multiline strings.

Example:

<cfset sql = "
	SELECT	*
	FROM	SomeTable
">

Stack Trace:

at Lexer._token (C:\Users\<User>\.vscode\extensions\vincaslt.highlight-matching-tag-0.8.3\node_modules\moo\moo.js:518:13)
at Lexer.next (C:\Users\<User>\.vscode\extensions\vincaslt.highlight-matching-tag-0.8.3\node_modules\moo\moo.js:465:19)
at Object.parseTags (C:\Users\<User>\.vscode\extensions\vincaslt.highlight-matching-tag-0.8.3\out\src\tagParser.js:79:36)
at context.subscriptions.push.vscode.window.onDidChangeTextEditorSelection.evt (C:\Users\<User>\.vscode\extensions\vincaslt.highlight-matching-tag-0.8.3\out\src\extension.js:60:36)
at e.fire (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:105:344)
at e.$acceptEditorPropertiesChanged (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:587:404)
at t._doInvokeHandler (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:609:757)
at t._invokeHandler (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:609:423)
at t._receiveRequest (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:608:15)
at t._receiveOneMessage (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:606:957)
at c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:604:773
at c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:103:886
at e.fire (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:105:344)
at a (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:156:881)
at Socket.n._socketDataListener (c:\Users\<User>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:157:95)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)
at readableAddChunk (_stream_readable.js:250:11)
at Socket.Readable.push (_stream_readable.js:208:10)
at Pipe.onread (net.js:594:20)

from vscode-highlight-matching-tag.

vincaslt avatar vincaslt commented on May 28, 2024

Your syntax is really stress-testing the regex rules :D
I'm not sure multiline string attributes is something I want to support, because it's not valid html or JSX syntax. I've added the support for them right now, but will only keep it if it doesn't break anything.

from vscode-highlight-matching-tag.

KamasamaK avatar KamasamaK commented on May 28, 2024

Sorry for the unusual cases, but I really appreciate it. I'm not familiar with JSX, but as far as I am aware, line feeds are valid in HTML attribute values.

from vscode-highlight-matching-tag.

vincaslt avatar vincaslt commented on May 28, 2024

You are right. Apparently you have to use solid tabs for indentation when doing multiline strings in html, probably it would work with spaces too, but they wouldn't be escaped.

from vscode-highlight-matching-tag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.