GithubHelp home page GithubHelp logo

Comments (3)

Macdu avatar Macdu commented on May 25, 2024

Prebuilt ffmpeg binaries were being used ever since Vita3K was release. It's just that previously the prebuilt were directly in the github repository (which was pretty bad) while now only the appropriate prebuilt is being downloaded when cmake is first run.

Also it's not like you have no idea how the prebuilts were generated, all of them are automatically generated on each new update by a CI and the code run on the CI to generate the libraries is available on the github repository.

from vita3k.

v-fox avatar v-fox commented on May 25, 2024

Also it's not like you have no idea how the prebuilts were generated, all of them are automatically generated on each new update by a CI and the code run on the CI to generate the libraries is available on the github repository.

Open-source is not ran on faith, it's ran on open source and there is no source. This downgrades whole project in effectively "proprietary freeware". Also, GPL requires you to publish all source used.

and the code run on the CI to generate the libraries is available on the github repository.

  1. I don't know where it supposed to be, but it doesn't seem to be in external/ffmpeg or Vita3K/ffmpeg-core/tree/master.
  2. Even if it was tucked somewhere and formal GPL requirement met, it's still horrible maintenance and disrespect to intent of GPL.

from vita3k.

KhoraLee avatar KhoraLee commented on May 25, 2024

I don't know where it supposed to be, but it doesn't seem to be in external/ffmpeg or Vita3K/ffmpeg-core/tree/master.

  1. VCPKG downloads ffmpeg code from ffmpeg's github mirror and apply patches. You can see how it is built at Github action's log.
    Patches: https://github.com/microsoft/vcpkg/tree/f6a5d4e8eb7476b8d7fc12a56dff300c1c986131/ports/ffmpeg
    Build log: https://github.com/Vita3K/ffmpeg-core/actions/runs/8255509666/job/22582128158

  2. ffmpeg is LGPL v2.1 not GPL since we do not pass --enable-gpl build option.

  3. Other OSS project uses such prebuilt library download process. For example IINA uses MPV(contains dynamic ffmpeg libraries) and download prebuilts from their private server (https://github.com/iina/iina?tab=readme-ov-file#using-the-pre-compiled-libraries). Also I don't get any difference with using package manager to download other libraries like OpenSSL.

from vita3k.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.