force option not working as documented about grive2

[memeplex]

I'm not 100% sure I'm correctly interpreting the option documentation.

Anyway, my use case is that I want to start with a "checkout" or "clone" of the server. For example, if I'm sync'ing my dotfiles to a new computer I don't want the .bashrc installed by default to override my custom .bashrc in drive at any rate!

[memeplex]

Seems like

        // if remote is modified
        if ( remote.MTime() > m_mtime )
        {
            Log( "file %1% is changed in remote", path, log::verbose ) ;
            m_state = remote_changed ;
        }

in Resource.cc is completely ignoring last_change, which is the mechanism by which force is implemented:

    if ( force )
    {
        m_last_change = DateTime() ;
        m_last_sync = DateTime::Now() ;
    }

[memeplex]

This could be a fix:

        // if remote is modified
        if ( remote.MTime() > last_change || remote.MTime() > m_mtime )
        {
            Log( "file %1% is changed in remote", path, log::verbose ) ;
            m_state = remote_changed ;
        }

but I think it would be more readable to explicity check the force flag instead of last_change.

[vitalif]

You're right, that's another bug introduced while trying to fix something...

I think the correct fix would be to change m_last_change to m_mtime in if(force)

That's of course nonsense, these are properties of different classes

[vitalif]

See the master branch. I've done a major rework today, adding support for local checksum and mtime cache ("index"). Force option should also work now :)